Re: [PATCH] add -Wun-def to global CFLAGS

2005-07-21 Thread Sam Ravnborg
On Thu, Jul 21, 2005 at 09:02:09PM +0200, Olaf Hering wrote: > > A recent change to the aic scsi driver removed two defines to detect > endianness. cpp handles undefined strings as 0. As a result, the test turned > into #if 0 == 0 and the wrong code was selected. > Adding -Wundef to global

[PATCH] add -Wun-def to global CFLAGS

2005-07-21 Thread Olaf Hering
A recent change to the aic scsi driver removed two defines to detect endianness. cpp handles undefined strings as 0. As a result, the test turned into #if 0 == 0 and the wrong code was selected. Adding -Wundef to global CFLAGS will catch such errors. Signed-off-by: Olaf Hering <[EMAIL

[PATCH] add -Wun-def to global CFLAGS

2005-07-21 Thread Olaf Hering
A recent change to the aic scsi driver removed two defines to detect endianness. cpp handles undefined strings as 0. As a result, the test turned into #if 0 == 0 and the wrong code was selected. Adding -Wundef to global CFLAGS will catch such errors. Signed-off-by: Olaf Hering [EMAIL PROTECTED]

Re: [PATCH] add -Wun-def to global CFLAGS

2005-07-21 Thread Sam Ravnborg
On Thu, Jul 21, 2005 at 09:02:09PM +0200, Olaf Hering wrote: A recent change to the aic scsi driver removed two defines to detect endianness. cpp handles undefined strings as 0. As a result, the test turned into #if 0 == 0 and the wrong code was selected. Adding -Wundef to global CFLAGS