Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-15 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: coul dyou try this against x86.git as well? We already unified ldt.c as part of the paravirt patches. Sure, but it may take me a little while. I've got the unified version here. thanks, applied.

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-15 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: >>> coul dyou try this against x86.git as well? We already unified ldt.c as >>> part of the paravirt patches. >>> >> >> Sure, but it may take me a little while. > > I've got the unified version here. thanks, applied. > Acked-by: Jeremy Fit

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-14 Thread Jeremy Fitzhardinge
Jan Beulich wrote: Ingo Molnar <[EMAIL PROTECTED]> 14.01.08 16:48 >>> * Jan Beulich <[EMAIL PROTECTED]> wrote: Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory (Xen requires GDT *and* LDT to be page-aligned). Using the page allocator interface also removes the

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-14 Thread Jan Beulich
>>> Ingo Molnar <[EMAIL PROTECTED]> 14.01.08 16:48 >>> > >* Jan Beulich <[EMAIL PROTECTED]> wrote: > >> Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory >> (Xen requires GDT *and* LDT to be page-aligned). Using the page >> allocator interface also removes the (albeit small) sla

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-14 Thread Ingo Molnar
* Jan Beulich <[EMAIL PROTECTED]> wrote: > Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory > (Xen requires GDT *and* LDT to be page-aligned). Using the page > allocator interface also removes the (albeit small) slab allocator > overhead. The same change being done for 64-bi

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-14 Thread Jan Beulich
>>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 11.01.08 18:28 >>> >Jan Beulich wrote: >> Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory >> (Xen requires GDT *and* LDT to be page-aligned). > >Can kmalloc return non-page-aligned PAGE_SIZE allocations? Documentation says it's to ret

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-11 Thread Jeremy Fitzhardinge
Jan Beulich wrote: Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory (Xen requires GDT *and* LDT to be page-aligned). Can kmalloc return non-page-aligned PAGE_SIZE allocations? Using the page allocator interface also removes the (albeit small) slab allocator overhead. Run

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-11 Thread Jan Beulich
>> --- linux-2.6.24-rc7/arch/x86/kernel/ldt_32.c2008-01-10 >> 16:53:54.0 +0100 >> +++ 2.6.24-rc7-x86-xen-ldt/arch/x86/kernel/ldt_32.c 2008-01-09 >> 13:59:50.0 +0100 >[...] >> @@ -73,7 +72,7 @@ static int alloc_ldt(mm_context_t *pc, u >> if (oldsize*LDT_ENTRY_

Re: [PATCH] adjust/fix LDT handling for Xen

2008-01-11 Thread Jiri Slaby
On 01/11/2008 10:22 AM, Jan Beulich wrote: Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory (Xen requires GDT *and* LDT to be page-aligned). Using the page allocator interface also removes the (albeit small) slab allocator overhead. The same change being done for 64-bits for co

[PATCH] adjust/fix LDT handling for Xen

2008-01-11 Thread Jan Beulich
Don't rely on kmalloc(PAGE_SIZE) returning PAGE_SIZE aligned memory (Xen requires GDT *and* LDT to be page-aligned). Using the page allocator interface also removes the (albeit small) slab allocator overhead. The same change being done for 64-bits for consistency. Further, the Xen hypercall interf