Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 16:24:52 +1100 > On PowerPC allmodconfig build we get this: > > net/key/af_key.c:400: warning: comparison is always false due to limited > range of data type > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> Applied, thank

[PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread Stephen Rothwell
On PowerPC allmodconfig build we get this: net/key/af_key.c:400: warning: comparison is always false due to limited range of data type Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- net/key/af_key.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) This version gets rid of

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 15:34:22 +1100 > On Tue, 30 Oct 2007 21:08:46 -0700 (PDT) David Miller <[EMAIL PROTECTED]> > wrote: > > I think we should retain the check, but modify it so that GCC knows we > > understand that it's OK if it is always false. Perh

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread Stephen Rothwell
On Tue, 30 Oct 2007 21:08:46 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > > I'm not so sure ifdef'ing things up all over the place is the way to > solve this. It makes the code ultra ugly. I agree. > I think we should retain the check, but modify it so that GCC knows we > understand tha

Re: [PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread David Miller
From: Stephen Rothwell <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 14:59:54 +1100 > On PowerPC allmodconfig build we get this: > > net/key/af_key.c:400: warning: comparison is always false due to limited > range of data type > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> ... > > +

[PATCH] af_key: suppress a warning for 64k pages.

2007-10-30 Thread Stephen Rothwell
On PowerPC allmodconfig build we get this: net/key/af_key.c:400: warning: comparison is always false due to limited range of data type Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- net/key/af_key.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) -- Cheers, Stephen Rothw