Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-04 Thread Andrey Ryabinin
On 07/04/14 14:27, Arnd Bergmann wrote: > On Friday 04 July 2014 11:13:31 Andrey Ryabinin wrote: >>> >>> but I wonder if there is a way to avoid the extra include here, as it might >>> also >>> cause a general slowdown because of asm/memory.h getting pulled into more .c >>> files. Would it be

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-04 Thread Arnd Bergmann
On Friday 04 July 2014 11:13:31 Andrey Ryabinin wrote: > > > > but I wonder if there is a way to avoid the extra include here, as it might > > also > > cause a general slowdown because of asm/memory.h getting pulled into more .c > > files. Would it be reasonable to hardcode PAGE_SIZE here? > >

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-04 Thread Andrey Ryabinin
On 07/04/14 00:24, Arnd Bergmann wrote: > On Wednesday 18 June 2014, Andrey Ryabinin wrote: >> diff --git a/arch/arm/include/asm/thread_info.h >> b/arch/arm/include/asm/thread_info.h >> index f989d7c..f85d2b0 100644 >> --- a/arch/arm/include/asm/thread_info.h >> +++

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-04 Thread Andrey Ryabinin
On 07/04/14 00:24, Arnd Bergmann wrote: On Wednesday 18 June 2014, Andrey Ryabinin wrote: diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h index f989d7c..f85d2b0 100644 --- a/arch/arm/include/asm/thread_info.h +++ b/arch/arm/include/asm/thread_info.h @@

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-04 Thread Arnd Bergmann
On Friday 04 July 2014 11:13:31 Andrey Ryabinin wrote: but I wonder if there is a way to avoid the extra include here, as it might also cause a general slowdown because of asm/memory.h getting pulled into more .c files. Would it be reasonable to hardcode PAGE_SIZE here? IMO it's

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-04 Thread Andrey Ryabinin
On 07/04/14 14:27, Arnd Bergmann wrote: On Friday 04 July 2014 11:13:31 Andrey Ryabinin wrote: but I wonder if there is a way to avoid the extra include here, as it might also cause a general slowdown because of asm/memory.h getting pulled into more .c files. Would it be reasonable to

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-03 Thread Arnd Bergmann
On Wednesday 18 June 2014, Andrey Ryabinin wrote: > diff --git a/arch/arm/include/asm/thread_info.h > b/arch/arm/include/asm/thread_info.h > index f989d7c..f85d2b0 100644 > --- a/arch/arm/include/asm/thread_info.h > +++ b/arch/arm/include/asm/thread_info.h > @@ -14,9 +14,10 @@ > > #include >

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-07-03 Thread Arnd Bergmann
On Wednesday 18 June 2014, Andrey Ryabinin wrote: diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h index f989d7c..f85d2b0 100644 --- a/arch/arm/include/asm/thread_info.h +++ b/arch/arm/include/asm/thread_info.h @@ -14,9 +14,10 @@ #include

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Andrey Ryabinin
On 06/18/14 18:40, Nicolas Pitre wrote: > On Wed, 18 Jun 2014, Andrey Ryabinin wrote: > >> Changing kernel stack size on arm is not as simple as it should be: >> 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER >> 2) stack size is hardcoded in get_thread_info macro >> >> This

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Andrey Ryabinin
On 06/18/14 18:31, Will Deacon wrote: > On Wed, Jun 18, 2014 at 02:50:22PM +0100, Andrey Ryabinin wrote: >> Changing kernel stack size on arm is not as simple as it should be: >> 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER > > THREAD_SIZE > Yup, I just found some more

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Nicolas Pitre
On Wed, 18 Jun 2014, Andrey Ryabinin wrote: > Changing kernel stack size on arm is not as simple as it should be: > 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER > 2) stack size is hardcoded in get_thread_info macro > > This patch fixes it by caculating THREAD_SIZE and

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Will Deacon
On Wed, Jun 18, 2014 at 02:50:22PM +0100, Andrey Ryabinin wrote: > Changing kernel stack size on arm is not as simple as it should be: > 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER THREAD_SIZE > 2) stack size is hardcoded in get_thread_info macro > > This patch fixes it

[PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Andrey Ryabinin
Changing kernel stack size on arm is not as simple as it should be: 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER 2) stack size is hardcoded in get_thread_info macro This patch fixes it by caculating THREAD_SIZE and thread_info address taking into account PAGE_SIZE and

[PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Andrey Ryabinin
Changing kernel stack size on arm is not as simple as it should be: 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER 2) stack size is hardcoded in get_thread_info macro This patch fixes it by caculating THREAD_SIZE and thread_info address taking into account PAGE_SIZE and

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Will Deacon
On Wed, Jun 18, 2014 at 02:50:22PM +0100, Andrey Ryabinin wrote: Changing kernel stack size on arm is not as simple as it should be: 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER THREAD_SIZE 2) stack size is hardcoded in get_thread_info macro This patch fixes it by

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Nicolas Pitre
On Wed, 18 Jun 2014, Andrey Ryabinin wrote: Changing kernel stack size on arm is not as simple as it should be: 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER 2) stack size is hardcoded in get_thread_info macro This patch fixes it by caculating THREAD_SIZE and

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Andrey Ryabinin
On 06/18/14 18:31, Will Deacon wrote: On Wed, Jun 18, 2014 at 02:50:22PM +0100, Andrey Ryabinin wrote: Changing kernel stack size on arm is not as simple as it should be: 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER THREAD_SIZE Yup, I just found some more typos in my

Re: [PATCH] arm: get rid of hardcoded assumptions about kernel stack size

2014-06-18 Thread Andrey Ryabinin
On 06/18/14 18:40, Nicolas Pitre wrote: On Wed, 18 Jun 2014, Andrey Ryabinin wrote: Changing kernel stack size on arm is not as simple as it should be: 1) THRED_SIZE macro doen't respect PAGE_SIZE and THREAD_SIZE_ORDER 2) stack size is hardcoded in get_thread_info macro This patch fixes it