Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-09-18 Thread Darren Hart
On Sat, Sep 03, 2016 at 08:51:26AM +0300, Giedrius Statkevičius wrote: > On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > > On Sat, Aug

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-09-18 Thread Darren Hart
On Sat, Sep 03, 2016 at 08:51:26AM +0300, Giedrius Statkevičius wrote: > On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > > On Sat, Aug

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-09-02 Thread Giedrius Statkevičius
On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > > > On Fri, Aug

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-09-02 Thread Giedrius Statkevičius
On Wed, Aug 17, 2016 at 11:23:15AM -0700, Darren Hart wrote: > On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > > > On Fri, Aug

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-17 Thread Darren Hart
On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > > On Fri, Aug

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-17 Thread Darren Hart
On Tue, Aug 16, 2016 at 12:49:50PM +0300, Giedrius Statkevičius wrote: > On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > > On Fri, Aug

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-16 Thread Giedrius Statkevičius
On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > > > parse_arg()

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-16 Thread Giedrius Statkevičius
On Fri, Aug 12, 2016 at 02:40:02PM -0700, Darren Hart wrote: > On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > > > parse_arg()

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-12 Thread Darren Hart
On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > >

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-12 Thread Darren Hart
On Sat, Aug 06, 2016 at 08:00:26PM +0300, Giedrius Statkevičius wrote: > On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > >

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-06 Thread Darren Hart
On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > function instead. There is no funcionality change except that in the > case of input being too big -ERANGE will be returned instead of -EINVAL > which

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-06 Thread Darren Hart
On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > function instead. There is no funcionality change except that in the > case of input being too big -ERANGE will be returned instead of -EINVAL > which

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-06 Thread Giedrius Statkevičius
On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > function instead. There is no funcionality change except that in the > > case of

Re: [PATCH] asus-laptop: get rid of parse_arg()

2016-08-06 Thread Giedrius Statkevičius
On Fri, Aug 05, 2016 at 04:15:07PM -0700, Darren Hart wrote: > On Fri, Aug 05, 2016 at 11:57:10PM +0300, Giedrius Statkevičius wrote: > > parse_arg() duplicates the funcionality of kstrtoint() so use the latter > > function instead. There is no funcionality change except that in the > > case of

[PATCH] asus-laptop: get rid of parse_arg()

2016-08-05 Thread Giedrius Statkevičius
parse_arg() duplicates the funcionality of kstrtoint() so use the latter function instead. There is no funcionality change except that in the case of input being too big -ERANGE will be returned instead of -EINVAL which is not bad because -ERANGE makes more sense here. The check for !count is

[PATCH] asus-laptop: get rid of parse_arg()

2016-08-05 Thread Giedrius Statkevičius
parse_arg() duplicates the funcionality of kstrtoint() so use the latter function instead. There is no funcionality change except that in the case of input being too big -ERANGE will be returned instead of -EINVAL which is not bad because -ERANGE makes more sense here. The check for !count is