Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-09 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 4:40 PM Brian Norris wrote: > > On Wed, Jul 8, 2020 at 4:14 PM Doug Anderson wrote: > > On Wed, Jul 8, 2020 at 4:03 PM Brian Norris > > wrote: > > > If I'm reading correctly, you're removing the only remaining use of > > > 'per_ce_irq'. Should we kill the field entir

Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-08 Thread Brian Norris
On Wed, Jul 8, 2020 at 4:14 PM Doug Anderson wrote: > On Wed, Jul 8, 2020 at 4:03 PM Brian Norris wrote: > > If I'm reading correctly, you're removing the only remaining use of > > 'per_ce_irq'. Should we kill the field entirely? > > Ah, you are indeed correct! I hadn't noticed that. Unless I h

Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-08 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 4:03 PM Brian Norris wrote: > > On Tue, Jul 7, 2020 at 10:18 AM Douglas Anderson > wrote: > > diff --git a/drivers/net/wireless/ath/ath10k/ce.h > > b/drivers/net/wireless/ath/ath10k/ce.h > > index a440aaf74aa4..666ce384a1d8 100644 > > --- a/drivers/net/wireless/ath/a

Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-08 Thread Brian Norris
On Tue, Jul 7, 2020 at 10:18 AM Douglas Anderson wrote: > diff --git a/drivers/net/wireless/ath/ath10k/ce.h > b/drivers/net/wireless/ath/ath10k/ce.h > index a440aaf74aa4..666ce384a1d8 100644 > --- a/drivers/net/wireless/ath/ath10k/ce.h > +++ b/drivers/net/wireless/ath/ath10k/ce.h ... > @@ -376,12

RE: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-08 Thread Rakesh Pillai
eaurora.org; > kua...@google.com; Douglas Anderson ; David > S. Miller ; Jakub Kicinski ; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject: [PATCH] ath10k: Keep track of which interrupts fired, don't poll > them > > If we have a per CE (Copy Engine) IRQ then we hav

[PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-07 Thread Douglas Anderson
If we have a per CE (Copy Engine) IRQ then we have no summary register. Right now the code generates a summary register by iterating over all copy engines and seeing if they have an interrupt pending. This has a problem. Specifically if _none_ if the Copy Engines have an interrupt pending then t