Re: [PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-29 Thread Ian Kent
On Mon, 2018-08-27 at 02:03 +0100, Al Viro wrote: > On Mon, Aug 20, 2018 at 04:37:09PM +0800, Ian Kent wrote: > > The autofs_sbi() inline function does not check the super block > > magic number to verify it has been given an autofs super block. > > IMO it's the wrong way to fix it. The one and

Re: [PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-29 Thread Ian Kent
On Mon, 2018-08-27 at 02:03 +0100, Al Viro wrote: > On Mon, Aug 20, 2018 at 04:37:09PM +0800, Ian Kent wrote: > > The autofs_sbi() inline function does not check the super block > > magic number to verify it has been given an autofs super block. > > IMO it's the wrong way to fix it. The one and

Re: [PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-26 Thread Al Viro
On Mon, Aug 20, 2018 at 04:37:09PM +0800, Ian Kent wrote: > The autofs_sbi() inline function does not check the super block > magic number to verify it has been given an autofs super block. IMO it's the wrong way to fix it. The one and only caller where that check might trigger is

Re: [PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-26 Thread Al Viro
On Mon, Aug 20, 2018 at 04:37:09PM +0800, Ian Kent wrote: > The autofs_sbi() inline function does not check the super block > magic number to verify it has been given an autofs super block. IMO it's the wrong way to fix it. The one and only caller where that check might trigger is

[PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-20 Thread Ian Kent
The autofs_sbi() inline function does not check the super block magic number to verify it has been given an autofs super block. Reported-by: syzbot+87c3c541582e56943...@syzkaller.appspotmail.com Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |4 +++- fs/autofs/inode.c|1 - 2 files

[PATCH] autofs - fix autofs_sbi() does not check super block type

2018-08-20 Thread Ian Kent
The autofs_sbi() inline function does not check the super block magic number to verify it has been given an autofs super block. Reported-by: syzbot+87c3c541582e56943...@syzkaller.appspotmail.com Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |4 +++- fs/autofs/inode.c|1 - 2 files