Re: [PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

2013-12-24 Thread Nishanth Aravamudan
On 23.12.2013 [17:37:00 -0800], Linus Torvalds wrote: > Please cc the guilty parties when sending patches like this. > > Also, just out of interest, please describe how this bug affected > things. Did we overflow the saved_auxv[] array, or what? Also, how > does this change affect architectures th

Re: [PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

2013-12-24 Thread Ard Biesheuvel
On 24 December 2013 02:37, Linus Torvalds wrote: > Please cc the guilty parties when sending patches like this. > OK. [Added Al Viro as well as this affects fs/binfmt_elf.c] > Also, just out of interest, please describe how this bug affected > things. Did we overflow the saved_auxv[] array, or w

Re: [PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

2013-12-24 Thread Michael Neuling
> Please cc the guilty parties when sending patches like this. Crud, sorry about that. Can we add a comment at the end of include/linux/auxvec.h that says you need to update this? Then plebs like me are less likely to miss it in future. Mikey > Also, just out of interest, please describe how t

Re: [PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

2013-12-23 Thread Linus Torvalds
Please cc the guilty parties when sending patches like this. Also, just out of interest, please describe how this bug affected things. Did we overflow the saved_auxv[] array, or what? Also, how does this change affect architectures that _don't_ have that ELF_HWCAP2 thing, ie everything but powerpc

[PATCH] auxvec.h: account for AT_HWCAP2 in AT_VECTOR_SIZE_BASE

2013-12-23 Thread Ard Biesheuvel
Commit 2171364d1a92 (powerpc: Add HWCAP2 aux entry) introduced a new AT_ auxv entry type AT_HWCAP2 but failed to update AT_VECTOR_SIZE_BASE accordingly. Signed-off-by: Ard Biesheuvel Fixes: 2171364d1a92 (powerpc: Add HWCAP2 aux entry) Cc: sta...@vger.kernel.org --- include/linux/auxvec.h | 2 +-