Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-08-14 Thread Coly Li
On 2019/8/14 10:23 下午, Heitor Alves de Siqueira wrote: > Hi Coly, > > We've had users impacted by system stalls and were able to trace it back to > the > bcache priority_stats query. After investigating a bit further, it seems that > the sorting step in the quantiles calculation can cause heavy

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-08-14 Thread Heitor Alves de Siqueira
Hi Coly, We've had users impacted by system stalls and were able to trace it back to the bcache priority_stats query. After investigating a bit further, it seems that the sorting step in the quantiles calculation can cause heavy CPU contention. This has a severe performance impact on any task

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Coly Li
On 2019/3/8 8:35 上午, Shile Zhang wrote: > > On 2019/3/7 23:44, Vojtech Pavlik wrote: >> On Thu, Mar 07, 2019 at 11:36:18PM +0800, Coly Li wrote: >>> On 2019/3/7 11:06 下午, Shile Zhang wrote: On 2019/3/7 18:34, Coly Li wrote: > On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote:

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Shile Zhang
On 2019/3/7 23:44, Vojtech Pavlik wrote: On Thu, Mar 07, 2019 at 11:36:18PM +0800, Coly Li wrote: On 2019/3/7 11:06 下午, Shile Zhang wrote: On 2019/3/7 18:34, Coly Li wrote: On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: From: Shile Zhang Read

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Vojtech Pavlik
On Thu, Mar 07, 2019 at 11:36:18PM +0800, Coly Li wrote: > On 2019/3/7 11:06 下午, Shile Zhang wrote: > > > > On 2019/3/7 18:34, Coly Li wrote: > >> On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: > >>> From: Shile Zhang > >>> > >>> Read /sys/fs/bcache//cacheN/priority_stats can take

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Coly Li
On 2019/3/7 11:06 下午, Shile Zhang wrote: > > On 2019/3/7 18:34, Coly Li wrote: >> On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: >>> From: Shile Zhang >>> >>> Read /sys/fs/bcache//cacheN/priority_stats can take very long >>> time with huge cache after long run. >>> >>> Signed-off-by:

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Shile Zhang
On 2019/3/7 18:34, Coly Li wrote: On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: From: Shile Zhang Read /sys/fs/bcache//cacheN/priority_stats can take very long time with huge cache after long run. Signed-off-by: Shile Zhang Hi Shile, Do you test your change ? It will be

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Coly Li
On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: > From: Shile Zhang > > Read /sys/fs/bcache//cacheN/priority_stats can take very long > time with huge cache after long run. > > Signed-off-by: Shile Zhang Hi Shile, Do you test your change ? It will be helpful with more performance

[PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-06 Thread shile . zhang
From: Shile Zhang Read /sys/fs/bcache//cacheN/priority_stats can take very long time with huge cache after long run. Signed-off-by: Shile Zhang --- drivers/md/bcache/sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index