Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-23 Thread Martin Steigerwald
Hi Jianchao. jianchao.wang - 17.04.18, 16:34: > On 04/17/2018 08:10 PM, Martin Steigerwald wrote: > > For testing it I add it to 4.16.2 with the patches I have already? > > You could try to only apply this patch to have a test. :) I tested 4.16.3 with just your patch (+ the unrelated btrfs

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-23 Thread Martin Steigerwald
Hi Jianchao. jianchao.wang - 17.04.18, 16:34: > On 04/17/2018 08:10 PM, Martin Steigerwald wrote: > > For testing it I add it to 4.16.2 with the patches I have already? > > You could try to only apply this patch to have a test. :) I tested 4.16.3 with just your patch (+ the unrelated btrfs

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-23 Thread Martin Steigerwald
Hi Jianchao. jianchao.wang - 17.04.18, 16:34: > On 04/17/2018 08:10 PM, Martin Steigerwald wrote: > > For testing it I add it to 4.16.2 with the patches I have already? > > You could try to only apply this patch to have a test. Compiling now to have a test. Thanks, -- Martin

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-23 Thread Martin Steigerwald
Hi Jianchao. jianchao.wang - 17.04.18, 16:34: > On 04/17/2018 08:10 PM, Martin Steigerwald wrote: > > For testing it I add it to 4.16.2 with the patches I have already? > > You could try to only apply this patch to have a test. Compiling now to have a test. Thanks, -- Martin

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-17 Thread jianchao.wang
Hi Martin On 04/17/2018 08:10 PM, Martin Steigerwald wrote: > For testing it I add it to 4.16.2 with the patches I have already? You could try to only apply this patch to have a test. :) > > - '[PATCH] blk-mq_Directly schedule q->timeout_work when aborting a > request.mbox' > > - '[PATCH v2]

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-17 Thread jianchao.wang
Hi Martin On 04/17/2018 08:10 PM, Martin Steigerwald wrote: > For testing it I add it to 4.16.2 with the patches I have already? You could try to only apply this patch to have a test. :) > > - '[PATCH] blk-mq_Directly schedule q->timeout_work when aborting a > request.mbox' > > - '[PATCH v2]

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-17 Thread Martin Steigerwald
Hi Jianchao, Jianchao Wang - 17.04.18, 05:46: > rq->gstate and rq->aborted_gstate both are zero before rqs are > allocated. If we have a small timeout, when the timer fires, > there could be rqs that are never allocated, and also there could > be rq that has been allocated but not initialized and

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-17 Thread Martin Steigerwald
Hi Jianchao, Jianchao Wang - 17.04.18, 05:46: > rq->gstate and rq->aborted_gstate both are zero before rqs are > allocated. If we have a small timeout, when the timer fires, > there could be rqs that are never allocated, and also there could > be rq that has been allocated but not initialized and

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Ming Lei
On Tue, Apr 17, 2018 at 11:46:20AM +0800, Jianchao Wang wrote: > rq->gstate and rq->aborted_gstate both are zero before rqs are > allocated. If we have a small timeout, when the timer fires, > there could be rqs that are never allocated, and also there could > be rq that has been allocated but not

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Ming Lei
On Tue, Apr 17, 2018 at 11:46:20AM +0800, Jianchao Wang wrote: > rq->gstate and rq->aborted_gstate both are zero before rqs are > allocated. If we have a small timeout, when the timer fires, > there could be rqs that are never allocated, and also there could > be rq that has been allocated but not

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Jens Axboe
On 4/16/18 9:46 PM, Jianchao Wang wrote: > rq->gstate and rq->aborted_gstate both are zero before rqs are > allocated. If we have a small timeout, when the timer fires, > there could be rqs that are never allocated, and also there could > be rq that has been allocated but not initialized and

Re: [PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Jens Axboe
On 4/16/18 9:46 PM, Jianchao Wang wrote: > rq->gstate and rq->aborted_gstate both are zero before rqs are > allocated. If we have a small timeout, when the timer fires, > there could be rqs that are never allocated, and also there could > be rq that has been allocated but not initialized and

[PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Jianchao Wang
rq->gstate and rq->aborted_gstate both are zero before rqs are allocated. If we have a small timeout, when the timer fires, there could be rqs that are never allocated, and also there could be rq that has been allocated but not initialized and started. At the moment, the rq->gstate and

[PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Jianchao Wang
rq->gstate and rq->aborted_gstate both are zero before rqs are allocated. If we have a small timeout, when the timer fires, there could be rqs that are never allocated, and also there could be rq that has been allocated but not initialized and started. At the moment, the rq->gstate and

[PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Jianchao Wang
rq->gstate and rq->aborted_gstate both are zero before rqs are allocated. If we have a small timeout, when the timer fires, there could be rqs that are never allocated, and also there could be rq that has been allocated but not initialized and started. At the moment, the rq->gstate and

[PATCH] blk-mq: start request gstate with gen 1

2018-04-16 Thread Jianchao Wang
rq->gstate and rq->aborted_gstate both are zero before rqs are allocated. If we have a small timeout, when the timer fires, there could be rqs that are never allocated, and also there could be rq that has been allocated but not initialized and started. At the moment, the rq->gstate and