Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread Joe Perches
On Thu, 2018-02-15 at 02:13 +, Al Viro wrote: > On Wed, Feb 14, 2018 at 08:37:02PM -0500, John Pittman wrote: > > In quite a few files throughout the block layer, the bare 'unsigned' is > > used rather than the preferred 'unsigned int'. > > Preferred by whom? The kernel as a whole, ~12:1 >

Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread Joe Perches
On Thu, 2018-02-15 at 02:13 +, Al Viro wrote: > On Wed, Feb 14, 2018 at 08:37:02PM -0500, John Pittman wrote: > > In quite a few files throughout the block layer, the bare 'unsigned' is > > used rather than the preferred 'unsigned int'. > > Preferred by whom? The kernel as a whole, ~12:1 >

Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread Al Viro
On Wed, Feb 14, 2018 at 08:37:02PM -0500, John Pittman wrote: > In quite a few files throughout the block layer, the bare 'unsigned' is > used rather than the preferred 'unsigned int'. Preferred by whom? > The issue was What is that "issue" and why is it a problem in the first place? >

Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread Al Viro
On Wed, Feb 14, 2018 at 08:37:02PM -0500, John Pittman wrote: > In quite a few files throughout the block layer, the bare 'unsigned' is > used rather than the preferred 'unsigned int'. Preferred by whom? > The issue was What is that "issue" and why is it a problem in the first place? >

Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread Jens Axboe
On 2/14/18 6:37 PM, John Pittman wrote: > In quite a few files throughout the block layer, the bare 'unsigned' is > used rather than the preferred 'unsigned int'. The issue was > exposed by checkpatch.pl. Warnings encountered were: > > WARNING: Prefer 'unsigned int' to bare use of

Re: [PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread Jens Axboe
On 2/14/18 6:37 PM, John Pittman wrote: > In quite a few files throughout the block layer, the bare 'unsigned' is > used rather than the preferred 'unsigned int'. The issue was > exposed by checkpatch.pl. Warnings encountered were: > > WARNING: Prefer 'unsigned int' to bare use of

[PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread John Pittman
In quite a few files throughout the block layer, the bare 'unsigned' is used rather than the preferred 'unsigned int'. The issue was exposed by checkpatch.pl. Warnings encountered were: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' WARNING: Prefer 'unsigned int *' to bare use

[PATCH] block: Change 'unsigned' to 'unsigned int' throughout block layer

2018-02-14 Thread John Pittman
In quite a few files throughout the block layer, the bare 'unsigned' is used rather than the preferred 'unsigned int'. The issue was exposed by checkpatch.pl. Warnings encountered were: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' WARNING: Prefer 'unsigned int *' to bare use