Re: [PATCH] block_dev: don't update file access position for sync direct IO

On Tue, Dec 13, 2016 at 09:08:18PM -0700, Jens Axboe wrote: > That's not great... Thanks, added. Ooops, yeah - we're still going through ->direct_IO for block devices. I'll take a stab at removing that, as it's just a pointless indirect call.

Re: [PATCH] block_dev: don't update file access position for sync direct IO

On Tue, Dec 13, 2016 at 09:08:18PM -0700, Jens Axboe wrote: > That's not great... Thanks, added. Ooops, yeah - we're still going through ->direct_IO for block devices. I'll take a stab at removing that, as it's just a pointless indirect call.

Re: [PATCH] block_dev: don't update file access position for sync direct IO

On 12/13/2016 08:07 PM, Shaohua Li wrote: > For sync direct IO, generic_file_direct_write/generic_file_read_iter > will update file access position. Don't duplicate the update in > .direct_IO. This cause my raid array can't assemble. That's not great... Thanks, added. -- Jens Axboe

Re: [PATCH] block_dev: don't update file access position for sync direct IO

On 12/13/2016 08:07 PM, Shaohua Li wrote: > For sync direct IO, generic_file_direct_write/generic_file_read_iter > will update file access position. Don't duplicate the update in > .direct_IO. This cause my raid array can't assemble. That's not great... Thanks, added. -- Jens Axboe

[PATCH] block_dev: don't update file access position for sync direct IO

For sync direct IO, generic_file_direct_write/generic_file_read_iter will update file access position. Don't duplicate the update in .direct_IO. This cause my raid array can't assemble. Cc: Christoph Hellwig Cc: Jens Axboe Signed-off-by: Shaohua Li ---

[PATCH] block_dev: don't update file access position for sync direct IO

For sync direct IO, generic_file_direct_write/generic_file_read_iter will update file access position. Don't duplicate the update in .direct_IO. This cause my raid array can't assemble. Cc: Christoph Hellwig Cc: Jens Axboe Signed-off-by: Shaohua Li --- fs/block_dev.c | 5 + 1 file