Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 08:49 +0200, Willy Tarreau wrote: > Hi Eric, > > On Wed, Aug 08, 2012 at 08:27:52AM +0200, Eric Dumazet wrote: > > On Wed, 2012-08-08 at 08:17 +0200, Willy Tarreau wrote: > > > > > > > > Well, if the drivers provided with the kernel don't work out of the box > > > anymore,

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Willy Tarreau
Hi Eric, On Wed, Aug 08, 2012 at 08:27:52AM +0200, Eric Dumazet wrote: > On Wed, 2012-08-08 at 08:17 +0200, Willy Tarreau wrote: > > > > > Well, if the drivers provided with the kernel don't work out of the box > > anymore, maybe we should also move them to a separate repository. All it > > is

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 08:17 +0200, Willy Tarreau wrote: > > Well, if the drivers provided with the kernel don't work out of the box > anymore, maybe we should also move them to a separate repository. All it > is going to do otherwise is to cause invalid bug reports because users > don't

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Willy Tarreau
On Tue, Aug 07, 2012 at 10:58:00PM -0700, David Miller wrote: > From: Jike Song > Date: Wed, 8 Aug 2012 13:50:42 +0800 > > > On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb wrote: > >> Commit c2c20ef43d00 "bnx2: Update driver to use new mips firmware" > >> updated the bnx2 driver to use

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Willy Tarreau
On Tue, Aug 07, 2012 at 10:58:00PM -0700, David Miller wrote: From: Jike Song albca...@gmail.com Date: Wed, 8 Aug 2012 13:50:42 +0800 On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb ch...@arachsys.com wrote: Commit c2c20ef43d00 bnx2: Update driver to use new mips firmware updated the bnx2

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 08:17 +0200, Willy Tarreau wrote: Well, if the drivers provided with the kernel don't work out of the box anymore, maybe we should also move them to a separate repository. All it is going to do otherwise is to cause invalid bug reports because users don't understand

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Willy Tarreau
Hi Eric, On Wed, Aug 08, 2012 at 08:27:52AM +0200, Eric Dumazet wrote: On Wed, 2012-08-08 at 08:17 +0200, Willy Tarreau wrote: Well, if the drivers provided with the kernel don't work out of the box anymore, maybe we should also move them to a separate repository. All it is going to

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-08 Thread Eric Dumazet
On Wed, 2012-08-08 at 08:49 +0200, Willy Tarreau wrote: Hi Eric, On Wed, Aug 08, 2012 at 08:27:52AM +0200, Eric Dumazet wrote: On Wed, 2012-08-08 at 08:17 +0200, Willy Tarreau wrote: Well, if the drivers provided with the kernel don't work out of the box anymore, maybe we should

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-07 Thread David Miller
From: Jike Song Date: Wed, 8 Aug 2012 13:50:42 +0800 > On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb wrote: >> Commit c2c20ef43d00 "bnx2: Update driver to use new mips firmware" >> updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of >> bnx2-mips-09-6.2.1a, but didn't replace the copy

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-07 Thread Jike Song
On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb wrote: > Commit c2c20ef43d00 "bnx2: Update driver to use new mips firmware" > updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of > bnx2-mips-09-6.2.1a, but didn't replace the copy of bnx2-mips-09-6.2.1a > in firmware/bnx2/ with the new

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-07 Thread Jike Song
On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb ch...@arachsys.com wrote: Commit c2c20ef43d00 bnx2: Update driver to use new mips firmware updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of bnx2-mips-09-6.2.1a, but didn't replace the copy of bnx2-mips-09-6.2.1a in firmware/bnx2/ with

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-08-07 Thread David Miller
From: Jike Song albca...@gmail.com Date: Wed, 8 Aug 2012 13:50:42 +0800 On Fri, Jul 13, 2012 at 9:04 PM, Chris Webb ch...@arachsys.com wrote: Commit c2c20ef43d00 bnx2: Update driver to use new mips firmware updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of bnx2-mips-09-6.2.1a,

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Ben Hutchings
On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote: > Eric Dumazet writes: > > > Have you read firmware/README.AddingFirmware ? > > I hadn't, but now I have, and if firmware upgrades are considered 'adding > new firmware', I agree this patch is wrong, and should have just removed the >

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Michael Chan
On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote: > Is there a more automatic method than going through the source for each > configured driver and setting CONFIG_EXTRA_FIRMWARE manually to list the > relevant firmwares? Is there any way to give the kernel the location of > linux-firmware and

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Chris Webb
Eric Dumazet writes: > Have you read firmware/README.AddingFirmware ? I hadn't, but now I have, and if firmware upgrades are considered 'adding new firmware', I agree this patch is wrong, and should have just removed the obsolete bnx2-mips-09-6.2.1a file that is no longer used by the bnx2

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Eric Dumazet
On Fri, 2012-07-13 at 14:04 +0100, Chris Webb wrote: > Commit c2c20ef43d00 "bnx2: Update driver to use new mips firmware" > updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of > bnx2-mips-09-6.2.1a, but didn't replace the copy of bnx2-mips-09-6.2.1a > in firmware/bnx2/ with the new

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Eric Dumazet
On Fri, 2012-07-13 at 14:04 +0100, Chris Webb wrote: Commit c2c20ef43d00 bnx2: Update driver to use new mips firmware updated the bnx2 driver to use bnx2-mips-09-6.2.1b in place of bnx2-mips-09-6.2.1a, but didn't replace the copy of bnx2-mips-09-6.2.1a in firmware/bnx2/ with the new version.

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Chris Webb
Eric Dumazet eric.duma...@gmail.com writes: Have you read firmware/README.AddingFirmware ? I hadn't, but now I have, and if firmware upgrades are considered 'adding new firmware', I agree this patch is wrong, and should have just removed the obsolete bnx2-mips-09-6.2.1a file that is no longer

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Michael Chan
On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote: Is there a more automatic method than going through the source for each configured driver and setting CONFIG_EXTRA_FIRMWARE manually to list the relevant firmwares? Is there any way to give the kernel the location of linux-firmware and have

Re: [PATCH] bnx2: update bnx2-mips-09 firmware to bnx2-mips-09-6.2.1b

2012-07-13 Thread Ben Hutchings
On Fri, 2012-07-13 at 15:09 +0100, Chris Webb wrote: Eric Dumazet eric.duma...@gmail.com writes: Have you read firmware/README.AddingFirmware ? I hadn't, but now I have, and if firmware upgrades are considered 'adding new firmware', I agree this patch is wrong, and should have just