Re: [PATCH] bpf: fix a race between perf_event_fd and kprobe freeing

2015-05-15 Thread Alexei Starovoitov
On 5/15/15 3:52 AM, Wang Nan wrote: According to Alexei Starovoitov (http://lkml.org/lkml/2015/5/15/29), there is racing between perf_event_fd and kprobe freeing: ... And he suggest to call perf_event_free_bpf_prog() from __free_event() instead of free_event_rcu() will fix the race, ...

[PATCH] bpf: fix a race between perf_event_fd and kprobe freeing

2015-05-15 Thread Wang Nan
According to Alexei Starovoitov (http://lkml.org/lkml/2015/5/15/29), there is racing between perf_event_fd and kprobe freeing: __free_event() event->destroy(event) perf_trace_destroy perf_trace_event_unreg which is dropping event->tp_event->perf_refcount that allows kprobe

[PATCH] bpf: fix a race between perf_event_fd and kprobe freeing

2015-05-15 Thread Wang Nan
According to Alexei Starovoitov (http://lkml.org/lkml/2015/5/15/29), there is racing between perf_event_fd and kprobe freeing: __free_event() event-destroy(event) perf_trace_destroy perf_trace_event_unreg which is dropping event-tp_event-perf_refcount that allows kprobe

Re: [PATCH] bpf: fix a race between perf_event_fd and kprobe freeing

2015-05-15 Thread Alexei Starovoitov
On 5/15/15 3:52 AM, Wang Nan wrote: According to Alexei Starovoitov (http://lkml.org/lkml/2015/5/15/29), there is racing between perf_event_fd and kprobe freeing: ... And he suggest to call perf_event_free_bpf_prog() from __free_event() instead of free_event_rcu() will fix the race, ...