Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 11 July 2017 at 17:01, Russell Joyce wrote: > Thanks for your comments. > >> What I think Rafał is saying is that it would be better to have this >> code in cfg80211 so other drivers including mac80211 could use it. > > > While I agree that moving all wireless LED

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 11 July 2017 at 17:01, Russell Joyce wrote: > Thanks for your comments. > >> What I think Rafał is saying is that it would be better to have this >> code in cfg80211 so other drivers including mac80211 could use it. > > > While I agree that moving all wireless LED triggers to cfg80211 would be

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

Thanks for your comments. > What I think Rafał is saying is that it would be better to have this > code in cfg80211 so other drivers including mac80211 could use it. While I agree that moving all wireless LED triggers to cfg80211 would be an ideal situation, it seems a bit out of scope for what

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

Thanks for your comments. > What I think Rafał is saying is that it would be better to have this > code in cfg80211 so other drivers including mac80211 could use it. While I agree that moving all wireless LED triggers to cfg80211 would be an ideal situation, it seems a bit out of scope for what

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 10-07-17 19:02, Russell Joyce wrote: >> 1) I think most of it should be some cfg80211 shareable code. > > I’m not sure exactly what you mean by this, could you please clarify? What I think Rafał is saying is that it would be better to have this code in cfg80211 so other drivers including

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 10-07-17 19:02, Russell Joyce wrote: >> 1) I think most of it should be some cfg80211 shareable code. > > I’m not sure exactly what you mean by this, could you please clarify? What I think Rafał is saying is that it would be better to have this code in cfg80211 so other drivers including

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

> 1) I think most of it should be some cfg80211 shareable code. I’m not sure exactly what you mean by this, could you please clarify? > 2) This "rxtx" while surely present in other places sounds like a > workaround for LED subsystem limitation. Maybe it's time to finally > rework LED triggers.

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

> 1) I think most of it should be some cfg80211 shareable code. I’m not sure exactly what you mean by this, could you please clarify? > 2) This "rxtx" while surely present in other places sounds like a > workaround for LED subsystem limitation. Maybe it's time to finally > rework LED triggers.

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 7 July 2017 at 16:09, Russell Joyce wrote: > Add three basic LED triggers to brcmfmac, based on those in mac80211: one > for transmit, one for receive, and one for combined transmit/receive. > > Signed-off-by: Russell Joyce 1) I think most

Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

On 7 July 2017 at 16:09, Russell Joyce wrote: > Add three basic LED triggers to brcmfmac, based on those in mac80211: one > for transmit, one for receive, and one for combined transmit/receive. > > Signed-off-by: Russell Joyce 1) I think most of it should be some cfg80211 shareable code. 2)

[PATCH] brcmfmac: added LED triggers for transmit/receive

Add three basic LED triggers to brcmfmac, based on those in mac80211: one for transmit, one for receive, and one for combined transmit/receive. Signed-off-by: Russell Joyce --- drivers/net/wireless/broadcom/brcm80211/Kconfig| 12 +++

[PATCH] brcmfmac: added LED triggers for transmit/receive

Add three basic LED triggers to brcmfmac, based on those in mac80211: one for transmit, one for receive, and one for combined transmit/receive. Signed-off-by: Russell Joyce --- drivers/net/wireless/broadcom/brcm80211/Kconfig| 12 +++ .../wireless/broadcom/brcm80211/brcmfmac/Makefile | 2