Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-30 Thread Arend Van Spriel
On 29-9-2016 23:57, Rafał Miłecki wrote: > On 27 September 2016 at 11:24, Arend Van Spriel > wrote: >> On 26-9-2016 14:38, Rafał Miłecki wrote: >>> On 26 September 2016 at 14:13, Rafał Miłecki wrote: On 26 September 2016 at 13:46, Arend Van

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-30 Thread Arend Van Spriel
On 29-9-2016 23:57, Rafał Miłecki wrote: > On 27 September 2016 at 11:24, Arend Van Spriel > wrote: >> On 26-9-2016 14:38, Rafał Miłecki wrote: >>> On 26 September 2016 at 14:13, Rafał Miłecki wrote: On 26 September 2016 at 13:46, Arend Van Spriel wrote: > On 26-9-2016 12:23,

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-29 Thread Rafał Miłecki
On 27 September 2016 at 11:24, Arend Van Spriel wrote: > On 26-9-2016 14:38, Rafał Miłecki wrote: >> On 26 September 2016 at 14:13, Rafał Miłecki wrote: >>> On 26 September 2016 at 13:46, Arend Van Spriel >>> wrote:

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-29 Thread Rafał Miłecki
On 27 September 2016 at 11:24, Arend Van Spriel wrote: > On 26-9-2016 14:38, Rafał Miłecki wrote: >> On 26 September 2016 at 14:13, Rafał Miłecki wrote: >>> On 26 September 2016 at 13:46, Arend Van Spriel >>> wrote: On 26-9-2016 12:23, Rafał Miłecki wrote: > From: Rafał Miłecki >

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-27 Thread Arend Van Spriel
On 26-9-2016 14:38, Rafał Miłecki wrote: > On 26 September 2016 at 14:13, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> wrote: >>> On 26-9-2016 12:23, Rafał Miłecki wrote: From: Rafał Miłecki

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-27 Thread Arend Van Spriel
On 26-9-2016 14:38, Rafał Miłecki wrote: > On 26 September 2016 at 14:13, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> wrote: >>> On 26-9-2016 12:23, Rafał Miłecki wrote: From: Rafał Miłecki We need to track 802.1x packets to know if there are any

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-27 Thread Arend Van Spriel
On 26-9-2016 16:59, Dan Williams wrote: > On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> wrote: >>> >>> On 26-9-2016 12:23, Rafał Miłecki wrote: From: Rafał Miłecki

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-27 Thread Arend Van Spriel
On 26-9-2016 16:59, Dan Williams wrote: > On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: >> On 26 September 2016 at 13:46, Arend Van Spriel >> wrote: >>> >>> On 26-9-2016 12:23, Rafał Miłecki wrote: From: Rafał Miłecki We need to track 802.1x packets to know if there

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Dan Williams
On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: > > > > On 26-9-2016 12:23, Rafał Miłecki wrote: > > > > > > From: Rafał Miłecki > > > > > > We need to track 802.1x packets to

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Dan Williams
On Mon, 2016-09-26 at 14:13 +0200, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: > > > > On 26-9-2016 12:23, Rafał Miłecki wrote: > > > > > > From: Rafał Miłecki > > > > > > We need to track 802.1x packets to know if there are any pending > > > ones > > > for

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Rafał Miłecki
On 26 September 2016 at 14:13, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: >> On 26-9-2016 12:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> We need to track 802.1x packets to know if

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Rafał Miłecki
On 26 September 2016 at 14:13, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: >> On 26-9-2016 12:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> We need to track 802.1x packets to know if there are any pending ones >>> for transmission. This is required

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Arend Van Spriel
On 26-9-2016 14:13, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: >> On 26-9-2016 12:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> We need to track 802.1x packets to know if there are any pending ones

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Arend Van Spriel
On 26-9-2016 14:13, Rafał Miłecki wrote: > On 26 September 2016 at 13:46, Arend Van Spriel > wrote: >> On 26-9-2016 12:23, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> We need to track 802.1x packets to know if there are any pending ones >>> for transmission. This is required for

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Rafał Miłecki
On 26 September 2016 at 13:46, Arend Van Spriel wrote: > On 26-9-2016 12:23, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> We need to track 802.1x packets to know if there are any pending ones >> for transmission. This is required for

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Rafał Miłecki
On 26 September 2016 at 13:46, Arend Van Spriel wrote: > On 26-9-2016 12:23, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> We need to track 802.1x packets to know if there are any pending ones >> for transmission. This is required for performing key update in the >> firmware. > > The problem

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Arend Van Spriel
On 26-9-2016 12:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > We need to track 802.1x packets to know if there are any pending ones > for transmission. This is required for performing key update in the > firmware. The problem we are trying to solve is a pretty old one.

Re: [PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Arend Van Spriel
On 26-9-2016 12:23, Rafał Miłecki wrote: > From: Rafał Miłecki > > We need to track 802.1x packets to know if there are any pending ones > for transmission. This is required for performing key update in the > firmware. The problem we are trying to solve is a pretty old one. The problem is that

[PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Rafał Miłecki
From: Rafał Miłecki We need to track 802.1x packets to know if there are any pending ones for transmission. This is required for performing key update in the firmware. Unfortunately our old tracking code wasn't very accurate. It was treating skb as pending as soon as it was

[PATCH] brcmfmac: implement more accurate skb tracking

2016-09-26 Thread Rafał Miłecki
From: Rafał Miłecki We need to track 802.1x packets to know if there are any pending ones for transmission. This is required for performing key update in the firmware. Unfortunately our old tracking code wasn't very accurate. It was treating skb as pending as soon as it was passed by the netif.