Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-18 Thread Sudeep Holla
Hi Huacai, On Thu, Oct 18, 2018 at 09:28:11AM +0800, Huacai Chen wrote: > Hi, Sudeep, > > Please see this call-graph: > > static int detect_cache_attributes(unsigned int cpu) > > ret = populate_cache_leaves(cpu); > > ret =

Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-18 Thread Sudeep Holla
Hi Huacai, On Thu, Oct 18, 2018 at 09:28:11AM +0800, Huacai Chen wrote: > Hi, Sudeep, > > Please see this call-graph: > > static int detect_cache_attributes(unsigned int cpu) > > ret = populate_cache_leaves(cpu); > > ret =

Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-17 Thread Huacai Chen
Hi, Sudeep, Please see this call-graph: static int detect_cache_attributes(unsigned int cpu) ret = populate_cache_leaves(cpu); ret = cache_shared_cpu_map_setup(cpu); --> cache_setup_of_node() --> cache_of_set_props() --> cache_size()/cache_nr_sets

Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-17 Thread Huacai Chen
Hi, Sudeep, Please see this call-graph: static int detect_cache_attributes(unsigned int cpu) ret = populate_cache_leaves(cpu); ret = cache_shared_cpu_map_setup(cpu); --> cache_setup_of_node() --> cache_of_set_props() --> cache_size()/cache_nr_sets

Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-17 Thread Sudeep Holla
On Wed, Oct 17, 2018 at 09:26:03AM +0800, Huacai Chen wrote: > Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF > property_read_u32 instead of get_property,read_number") makes cache > size and number_of_sets be 0 if DT doesn't provide there values. I > think this is unreasonable

Re: [PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-17 Thread Sudeep Holla
On Wed, Oct 17, 2018 at 09:26:03AM +0800, Huacai Chen wrote: > Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF > property_read_u32 instead of get_property,read_number") makes cache > size and number_of_sets be 0 if DT doesn't provide there values. I > think this is unreasonable

[PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-16 Thread Huacai Chen
Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number") makes cache size and number_of_sets be 0 if DT doesn't provide there values. I think this is unreasonable so make them keep the old values, which is the same as old kernels.

[PATCH] cacheinfo: Keep the old value if of_property_read_u32 fails

2018-10-16 Thread Huacai Chen
Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number") makes cache size and number_of_sets be 0 if DT doesn't provide there values. I think this is unreasonable so make them keep the old values, which is the same as old kernels.