Re: [PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread David Brownell
On Thursday 14 February 2008, Uwe Kleine-König wrote: > If you have GPIO_LIB gpio_cansleep oopses on an invalid > gpio. So better gpio_request your pin first. > > Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> > Cc: David Brownell <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL

Re: [PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread Uwe Kleine-König
Hello, Uwe Kleine-König wrote: > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 6c0a9c4..76ddcf3 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -79,6 +79,10 @@ static int gpio_led_probe(struct platform_device *pdev) > cur_led

[PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread Uwe Kleine-König
If you have GPIO_LIB gpio_cansleep oopses on an invalid gpio. So better gpio_request your pin first. Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]> Cc: David Brownell <[EMAIL PROTECTED]> Cc: Raphael Assenat <[EMAIL PROTECTED]> Cc: Richard Purdie <[EMAIL PROTECTED]> --- Hello, I currently

[PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread Uwe Kleine-König
If you have GPIO_LIB gpio_cansleep oopses on an invalid gpio. So better gpio_request your pin first. Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] Cc: David Brownell [EMAIL PROTECTED] Cc: Raphael Assenat [EMAIL PROTECTED] Cc: Richard Purdie [EMAIL PROTECTED] --- Hello, I currently start

Re: [PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread Uwe Kleine-König
Hello, Uwe Kleine-König wrote: diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 6c0a9c4..76ddcf3 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -79,6 +79,10 @@ static int gpio_led_probe(struct platform_device *pdev) cur_led =

Re: [PATCH] call gpio_cansleep only after gpio_request succeeded

2008-02-14 Thread David Brownell
On Thursday 14 February 2008, Uwe Kleine-König wrote: If you have GPIO_LIB gpio_cansleep oopses on an invalid gpio. So better gpio_request your pin first. Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] Cc: David Brownell [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] ...