Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

2019-07-26 Thread Jeroen Hofstee
Hello Marc, On 7/26/19 1:48 PM, Marc Kleine-Budde wrote: > On 4/29/19 2:03 PM, Jeroen Hofstee wrote: > >> @@ -744,8 +652,8 @@ static irqreturn_t ti_hecc_interrupt(int irq, void >> *dev_id) >> struct net_device *ndev = (struct net_device *)dev_id; >> struct ti_hecc_priv *priv =

Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

2019-07-26 Thread Marc Kleine-Budde
On 4/29/19 2:03 PM, Jeroen Hofstee wrote: > As already mentioned in [1] and included in [2], there is an off by one > issue since the high bank is already enabled when the _next_ mailbox to > be read has index 12, so the mailbox being read was 13. The message can > therefore go into mailbox 31 and

Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-04-29 at 12:03 +, Jeroen Hofstee wrote: > As already mentioned in [1] and included in [2], there is an off by > one > issue since the high bank is already enabled when the _next_ mailbox > to > be read has index 12, so the mailbox being read was 13. The message > can > therefore

Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

2019-07-24 Thread Jeroen Hofstee
Hello Marc, On 7/24/19 10:26 AM, Marc Kleine-Budde wrote: > On 4/29/19 2:03 PM, Jeroen Hofstee wrote: >> As already mentioned in [1] and included in [2], there is an off by one >> issue since the high bank is already enabled when the _next_ mailbox to >> be read has index 12, so the mailbox being

Re: [PATCH] can: ti_hecc: use timestamp based rx-offloading

2019-07-24 Thread Marc Kleine-Budde
On 4/29/19 2:03 PM, Jeroen Hofstee wrote: > As already mentioned in [1] and included in [2], there is an off by one > issue since the high bank is already enabled when the _next_ mailbox to > be read has index 12, so the mailbox being read was 13. The message can > therefore go into mailbox 31 and