Re: [PATCH] cgroup/tracing: Move taking of spin lock out of trace event handlers

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 05:48:54PM -0400, Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > It is unwise to take spin locks from the handlers of trace events. > Mainly, because they can introduce lockups, because it introduces locks > in places that are normally not tested. Worse yet,

Re: [PATCH] cgroup/tracing: Move taking of spin lock out of trace event handlers

2018-07-11 Thread Tejun Heo
On Mon, Jul 09, 2018 at 05:48:54PM -0400, Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > It is unwise to take spin locks from the handlers of trace events. > Mainly, because they can introduce lockups, because it introduces locks > in places that are normally not tested. Worse yet,

Re: [PATCH] cgroup/tracing: Move taking of spin lock out of trace event handlers

2018-07-10 Thread Sebastian Andrzej Siewior
On 2018-07-09 17:48:54 [-0400], Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > Reported-by: Sebastian Andrzej Siewior Reported-by: Clark Williams I just forwarded the report. > Signed-off-by: Steven Rostedt (VMware) I am in favour of this change. Sebastian

Re: [PATCH] cgroup/tracing: Move taking of spin lock out of trace event handlers

2018-07-10 Thread Sebastian Andrzej Siewior
On 2018-07-09 17:48:54 [-0400], Steven Rostedt wrote: > From: Steven Rostedt (VMware) > > Reported-by: Sebastian Andrzej Siewior Reported-by: Clark Williams I just forwarded the report. > Signed-off-by: Steven Rostedt (VMware) I am in favour of this change. Sebastian

[PATCH] cgroup/tracing: Move taking of spin lock out of trace event handlers

2018-07-09 Thread Steven Rostedt
From: Steven Rostedt (VMware) It is unwise to take spin locks from the handlers of trace events. Mainly, because they can introduce lockups, because it introduces locks in places that are normally not tested. Worse yet, because trace events are tucked away in the include/trace/events/ directory,

[PATCH] cgroup/tracing: Move taking of spin lock out of trace event handlers

2018-07-09 Thread Steven Rostedt
From: Steven Rostedt (VMware) It is unwise to take spin locks from the handlers of trace events. Mainly, because they can introduce lockups, because it introduces locks in places that are normally not tested. Worse yet, because trace events are tucked away in the include/trace/events/ directory,