Re: [PATCH] cgroup: add tracepoints for basic operations

2016-08-10 Thread Tejun Heo 
On Tue, Aug 09, 2016 at 01:27:03AM -0400, Tejun Heo wrote:
> From 471f89b317a21a78dacaee85957984b9f11e79e4 Mon Sep 17 00:00:00 2001
> From: Tejun Heo 
> Date: Tue, 9 Aug 2016 01:11:13 -0400
> 
> Debugging what goes wrong with cgroup setup can get hairy.  Add
> tracepoints for cgroup hierarchy mount, cgroup creation/destruction
> and task migration operations for better visibility.
> 
> Signed-off-by: Tejun Heo 

Applied to cgroup/for-4.9.

Thanks.

-- 
tejun

Re: [PATCH] cgroup: add tracepoints for basic operations

2016-08-10 Thread Tejun Heo 
On Tue, Aug 09, 2016 at 01:27:03AM -0400, Tejun Heo wrote:
> From 471f89b317a21a78dacaee85957984b9f11e79e4 Mon Sep 17 00:00:00 2001
> From: Tejun Heo 
> Date: Tue, 9 Aug 2016 01:11:13 -0400
> 
> Debugging what goes wrong with cgroup setup can get hairy.  Add
> tracepoints for cgroup hierarchy mount, cgroup creation/destruction
> and task migration operations for better visibility.
> 
> Signed-off-by: Tejun Heo 

Applied to cgroup/for-4.9.

Thanks.

-- 
tejun

[PATCH] cgroup: add tracepoints for basic operations

2016-08-08 Thread Tejun Heo 
>From 471f89b317a21a78dacaee85957984b9f11e79e4 Mon Sep 17 00:00:00 2001
From: Tejun Heo 
Date: Tue, 9 Aug 2016 01:11:13 -0400

Debugging what goes wrong with cgroup setup can get hairy.  Add
tracepoints for cgroup hierarchy mount, cgroup creation/destruction
and task migration operations for better visibility.

Signed-off-by: Tejun Heo 
---
This patchset is on top of

  v4.8-rc1 29b4817d4018df78086157ea3a55c1d9424a7cfc
+ [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in 
strlcpy() style
  http://lkml.kernel.org/r/1470720204-4605-1-git-send-email...@kernel.org

and also available in the following git branch.

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-tracepoints

Thanks.

 include/trace/events/cgroup.h | 163 ++
 kernel/cgroup.c   |  25 +++
 2 files changed, 188 insertions(+)
 create mode 100644 include/trace/events/cgroup.h

diff --git a/include/trace/events/cgroup.h b/include/trace/events/cgroup.h
new file mode 100644
index 000..ab68640
--- /dev/null
+++ b/include/trace/events/cgroup.h
@@ -0,0 +1,163 @@
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM cgroup
+
+#if !defined(_TRACE_CGROUP_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_CGROUP_H
+
+#include 
+#include 
+
+DECLARE_EVENT_CLASS(cgroup_root,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root),
+
+   TP_STRUCT__entry(
+   __field(int,root)
+   __field(u16,ss_mask )
+   __string(   name,   root->name  )
+   ),
+
+   TP_fast_assign(
+   __entry->root = root->hierarchy_id;
+   __entry->ss_mask = root->subsys_mask;
+   __assign_str(name, root->name);
+   ),
+
+   TP_printk("root=%d ss_mask=%#x name=%s",
+ __entry->root, __entry->ss_mask, __get_str(name))
+);
+
+DEFINE_EVENT(cgroup_root, cgroup_setup_root,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root)
+);
+
+DEFINE_EVENT(cgroup_root, cgroup_destroy_root,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root)
+);
+
+DEFINE_EVENT(cgroup_root, cgroup_remount,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root)
+);
+
+DECLARE_EVENT_CLASS(cgroup,
+
+   TP_PROTO(struct cgroup *cgrp),
+
+   TP_ARGS(cgrp),
+
+   TP_STRUCT__entry(
+   __field(int,root)
+   __field(int,id  )
+   __field(int,level   )
+   __dynamic_array(char,   path,
+   cgrp->kn ? cgroup_path(cgrp, NULL, 0) + 1
+: strlen("(null)"))
+   ),
+
+   TP_fast_assign(
+   __entry->root = cgrp->root->hierarchy_id;
+   __entry->id = cgrp->id;
+   __entry->level = cgrp->level;
+   if (cgrp->kn)
+   cgroup_path(cgrp, __get_dynamic_array(path),
+   __get_dynamic_array_len(path));
+   else
+   __assign_str(path, "(null)");
+   ),
+
+   TP_printk("root=%d id=%d level=%d path=%s",
+ __entry->root, __entry->id, __entry->level, __get_str(path))
+);
+
+DEFINE_EVENT(cgroup, cgroup_mkdir,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DEFINE_EVENT(cgroup, cgroup_rmdir,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DEFINE_EVENT(cgroup, cgroup_release,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DEFINE_EVENT(cgroup, cgroup_rename,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DECLARE_EVENT_CLASS(cgroup_migrate,
+
+   TP_PROTO(struct cgroup *dst_cgrp, struct task_struct *task, bool 
threadgroup),
+
+   TP_ARGS(dst_cgrp, task, threadgroup),
+
+   TP_STRUCT__entry(
+   __field(int,dst_root)
+   __field(int,dst_id  )
+   __field(int,dst_level   )
+   __dynamic_array(char,   dst_path,
+   dst_cgrp->kn ? cgroup_path(dst_cgrp, NULL, 0) + 
1
+: strlen("(null)"))
+   __field(int,pid )
+   __string(   comm,   task->comm  )
+   ),
+
+   TP_fast_assign(
+   __entry->dst_root = dst_cgrp->root->hierarchy_id;
+   __entry->dst_id = dst_cgrp->id;
+   __entry->dst_level = dst_cgrp->level;
+   if (dst_cgrp->kn)
+

[PATCH] cgroup: add tracepoints for basic operations

2016-08-08 Thread Tejun Heo 
>From 471f89b317a21a78dacaee85957984b9f11e79e4 Mon Sep 17 00:00:00 2001
From: Tejun Heo 
Date: Tue, 9 Aug 2016 01:11:13 -0400

Debugging what goes wrong with cgroup setup can get hairy.  Add
tracepoints for cgroup hierarchy mount, cgroup creation/destruction
and task migration operations for better visibility.

Signed-off-by: Tejun Heo 
---
This patchset is on top of

  v4.8-rc1 29b4817d4018df78086157ea3a55c1d9424a7cfc
+ [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in 
strlcpy() style
  http://lkml.kernel.org/r/1470720204-4605-1-git-send-email...@kernel.org

and also available in the following git branch.

  git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-tracepoints

Thanks.

 include/trace/events/cgroup.h | 163 ++
 kernel/cgroup.c   |  25 +++
 2 files changed, 188 insertions(+)
 create mode 100644 include/trace/events/cgroup.h

diff --git a/include/trace/events/cgroup.h b/include/trace/events/cgroup.h
new file mode 100644
index 000..ab68640
--- /dev/null
+++ b/include/trace/events/cgroup.h
@@ -0,0 +1,163 @@
+#undef TRACE_SYSTEM
+#define TRACE_SYSTEM cgroup
+
+#if !defined(_TRACE_CGROUP_H) || defined(TRACE_HEADER_MULTI_READ)
+#define _TRACE_CGROUP_H
+
+#include 
+#include 
+
+DECLARE_EVENT_CLASS(cgroup_root,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root),
+
+   TP_STRUCT__entry(
+   __field(int,root)
+   __field(u16,ss_mask )
+   __string(   name,   root->name  )
+   ),
+
+   TP_fast_assign(
+   __entry->root = root->hierarchy_id;
+   __entry->ss_mask = root->subsys_mask;
+   __assign_str(name, root->name);
+   ),
+
+   TP_printk("root=%d ss_mask=%#x name=%s",
+ __entry->root, __entry->ss_mask, __get_str(name))
+);
+
+DEFINE_EVENT(cgroup_root, cgroup_setup_root,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root)
+);
+
+DEFINE_EVENT(cgroup_root, cgroup_destroy_root,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root)
+);
+
+DEFINE_EVENT(cgroup_root, cgroup_remount,
+
+   TP_PROTO(struct cgroup_root *root),
+
+   TP_ARGS(root)
+);
+
+DECLARE_EVENT_CLASS(cgroup,
+
+   TP_PROTO(struct cgroup *cgrp),
+
+   TP_ARGS(cgrp),
+
+   TP_STRUCT__entry(
+   __field(int,root)
+   __field(int,id  )
+   __field(int,level   )
+   __dynamic_array(char,   path,
+   cgrp->kn ? cgroup_path(cgrp, NULL, 0) + 1
+: strlen("(null)"))
+   ),
+
+   TP_fast_assign(
+   __entry->root = cgrp->root->hierarchy_id;
+   __entry->id = cgrp->id;
+   __entry->level = cgrp->level;
+   if (cgrp->kn)
+   cgroup_path(cgrp, __get_dynamic_array(path),
+   __get_dynamic_array_len(path));
+   else
+   __assign_str(path, "(null)");
+   ),
+
+   TP_printk("root=%d id=%d level=%d path=%s",
+ __entry->root, __entry->id, __entry->level, __get_str(path))
+);
+
+DEFINE_EVENT(cgroup, cgroup_mkdir,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DEFINE_EVENT(cgroup, cgroup_rmdir,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DEFINE_EVENT(cgroup, cgroup_release,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DEFINE_EVENT(cgroup, cgroup_rename,
+
+   TP_PROTO(struct cgroup *cgroup),
+
+   TP_ARGS(cgroup)
+);
+
+DECLARE_EVENT_CLASS(cgroup_migrate,
+
+   TP_PROTO(struct cgroup *dst_cgrp, struct task_struct *task, bool 
threadgroup),
+
+   TP_ARGS(dst_cgrp, task, threadgroup),
+
+   TP_STRUCT__entry(
+   __field(int,dst_root)
+   __field(int,dst_id  )
+   __field(int,dst_level   )
+   __dynamic_array(char,   dst_path,
+   dst_cgrp->kn ? cgroup_path(dst_cgrp, NULL, 0) + 
1
+: strlen("(null)"))
+   __field(int,pid )
+   __string(   comm,   task->comm  )
+   ),
+
+   TP_fast_assign(
+   __entry->dst_root = dst_cgrp->root->hierarchy_id;
+   __entry->dst_id = dst_cgrp->id;
+   __entry->dst_level = dst_cgrp->level;
+   if (dst_cgrp->kn)
+   cgroup_path(dst_cgrp, __get_dynamic_array(dst_path),