Re: [PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-17 Thread Arnd Bergmann
On Monday, October 17, 2016 1:22:01 PM CEST Lubomir Rintel wrote: > > > > And why do you need a char device for this type of > > > > hardware? Isn't there already an existing interface for this device > > > > class? > > > > > > (Arnd answered this better than I would do in his response to this >

Re: [PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-17 Thread Lubomir Rintel
On Sun, 2016-10-16 at 11:57 +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 16, 2016 at 11:23:36AM +0200, Lubomir Rintel wrote: > > > > Hi Greg, > > > > (responses inline) > > > > On Mon, 2016-10-10 at 19:33 +0200, Greg Kroah-Hartman wrote: > > > > > > On Mon, Oct 10, 2016 at 05:58:15PM +0200, L

Re: [PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-16 Thread Greg Kroah-Hartman
On Sun, Oct 16, 2016 at 11:23:36AM +0200, Lubomir Rintel wrote: > Hi Greg, > > (responses inline) > > On Mon, 2016-10-10 at 19:33 +0200, Greg Kroah-Hartman wrote: > > On Mon, Oct 10, 2016 at 05:58:15PM +0200, Lubomir Rintel wrote: > > > > > > This implements only the very basic protocol "Mode A"

Re: [PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-16 Thread Lubomir Rintel
Hi Greg, (responses inline) On Mon, 2016-10-10 at 19:33 +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 10, 2016 at 05:58:15PM +0200, Lubomir Rintel wrote: > > > > This implements only the very basic protocol "Mode A", just to make > > the > > device functional. Patches to implement "Mode C" that

Re: [PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-10 Thread Arnd Bergmann
On Monday, October 10, 2016 7:33:45 PM CEST Greg Kroah-Hartman wrote: > > + > > +#define SCR24X_DEVS 8 > > +static DECLARE_BITMAP(scr24x_minors, SCR24X_DEVS); > > + > > +static struct class *scr24x_class; > > +dev_t scr24x_devt; > > global variable? And why do you need a char device for this type

Re: [PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-10 Thread Greg Kroah-Hartman
On Mon, Oct 10, 2016 at 05:58:15PM +0200, Lubomir Rintel wrote: > This implements only the very basic protocol "Mode A", just to make the > device functional. Patches to implement "Mode C" that uses better bulking > and is interrupt-driver may follow. > > The device essentially speaks the same pro

[PATCH] char/pcmcia: add scr24x_cs chip card interface driver

2016-10-10 Thread Lubomir Rintel
This implements only the very basic protocol "Mode A", just to make the device functional. Patches to implement "Mode C" that uses better bulking and is interrupt-driver may follow. The device essentially speaks the same protocol as USB CCID devices do over the bulk endpoints. The driver exchanges