Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-15 Thread One Thousand Gnomes
Which kernel did you see the write_room oops ? and I'll double check its all fixed. > >> + ublox_gps_i2c_client = client; > >> + ublox_gps_filp = NULL; > >> + ublox_gps_tty_port = NULL; > >> + ublox_gps_is_open = false; > > > > There are some other i2c based tty drivers in the

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-15 Thread One Thousand Gnomes
Which kernel did you see the write_room oops ? and I'll double check its all fixed. + ublox_gps_i2c_client = client; + ublox_gps_filp = NULL; + ublox_gps_tty_port = NULL; + ublox_gps_is_open = false; There are some other i2c based tty drivers in the kernel - notably

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-14 Thread Greg Kroah-Hartman
On Wed, Jan 14, 2015 at 10:39:04AM -0800, Felipe Tonello wrote: > The thing is that: I wrote this driver to work with only one gps > module, because that's my configuration here. I cannot really test > multiple i2c gps at the same time. If you guys really want a driver > that works for multiple

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-14 Thread Felipe Tonello
Hi Alan, On Wed, Jan 14, 2015 at 7:48 AM, One Thousand Gnomes wrote: > On Tue, 13 Jan 2015 17:16:42 -0800 > "Felipe F. Tonello" wrote: > >> This driver will basically translate serial communication to i2c >> communication >> between the user-space and the GPS module. >> >> It creates a

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-14 Thread One Thousand Gnomes
On Tue, 13 Jan 2015 17:16:42 -0800 "Felipe F. Tonello" wrote: > This driver will basically translate serial communication to i2c communication > between the user-space and the GPS module. > > It creates a /dev/ttyS device node. It shouldn't. It should use its own name. (ttyubl or something ..

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-14 Thread Greg Kroah-Hartman
On Wed, Jan 14, 2015 at 10:39:04AM -0800, Felipe Tonello wrote: The thing is that: I wrote this driver to work with only one gps module, because that's my configuration here. I cannot really test multiple i2c gps at the same time. If you guys really want a driver that works for multiple gps

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-14 Thread One Thousand Gnomes
On Tue, 13 Jan 2015 17:16:42 -0800 Felipe F. Tonello e...@felipetonello.com wrote: This driver will basically translate serial communication to i2c communication between the user-space and the GPS module. It creates a /dev/ttyS device node. It shouldn't. It should use its own name. (ttyubl

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-14 Thread Felipe Tonello
Hi Alan, On Wed, Jan 14, 2015 at 7:48 AM, One Thousand Gnomes gno...@lxorguk.ukuu.org.uk wrote: On Tue, 13 Jan 2015 17:16:42 -0800 Felipe F. Tonello e...@felipetonello.com wrote: This driver will basically translate serial communication to i2c communication between the user-space and the

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 06:07:27PM -0800, Felipe Tonello wrote: > >> +static void ublox_gps_read_worker(struct work_struct *private); > >> + > >> +static DECLARE_DELAYED_WORK(ublox_gps_wq, ublox_gps_read_worker); > > > > Again, make device-specific. > > > >> +static void

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Felipe Tonello
Hi Greg, On Tue, Jan 13, 2015 at 5:33 PM, Greg Kroah-Hartman wrote: > On Tue, Jan 13, 2015 at 05:16:42PM -0800, Felipe F. Tonello wrote: >> This driver will basically translate serial communication to i2c >> communication >> between the user-space and the GPS module. >> >> It creates a

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 05:16:42PM -0800, Felipe F. Tonello wrote: > This driver will basically translate serial communication to i2c communication > between the user-space and the GPS module. > > It creates a /dev/ttyS device node. > > There are specific tty termios flags in order to the tty

[PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Felipe F. Tonello
This driver will basically translate serial communication to i2c communication between the user-space and the GPS module. It creates a /dev/ttyS device node. There are specific tty termios flags in order to the tty line discipliner not to change the date it is pushed to user space. That is

[PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Felipe F. Tonello
This driver will basically translate serial communication to i2c communication between the user-space and the GPS module. It creates a /dev/ttyS device node. There are specific tty termios flags in order to the tty line discipliner not to change the date it is pushed to user space. That is

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 05:16:42PM -0800, Felipe F. Tonello wrote: This driver will basically translate serial communication to i2c communication between the user-space and the GPS module. It creates a /dev/ttyS device node. There are specific tty termios flags in order to the tty line

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 06:07:27PM -0800, Felipe Tonello wrote: +static void ublox_gps_read_worker(struct work_struct *private); + +static DECLARE_DELAYED_WORK(ublox_gps_wq, ublox_gps_read_worker); Again, make device-specific. +static void ublox_gps_read_worker(struct work_struct

Re: [PATCH] char: Added support for u-blox 6 i2c gps driver

2015-01-13 Thread Felipe Tonello
Hi Greg, On Tue, Jan 13, 2015 at 5:33 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Jan 13, 2015 at 05:16:42PM -0800, Felipe F. Tonello wrote: This driver will basically translate serial communication to i2c communication between the user-space and the GPS module. It