[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-03 Thread Max Bires
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-03 Thread Max Bires
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 04:53:13AM -0800, Max Bires wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel,

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-03 Thread Greg KH
On Tue, Jan 03, 2017 at 04:53:13AM -0800, Max Bires wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel,

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-03 Thread Max Bires
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-03 Thread Max Bires
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-02 Thread Arnd Bergmann
On Tuesday, December 27, 2016 3:05:54 PM CET Max Bires wrote: > So this is fine as is then? Just making sure that outside of the > development tree being closed for now that this patch is good to go now > that space/tab formatting is fixed. Yes, the change is fine, please add my Acked-by: Arnd

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2017-01-02 Thread Arnd Bergmann
On Tuesday, December 27, 2016 3:05:54 PM CET Max Bires wrote: > So this is fine as is then? Just making sure that outside of the > development tree being closed for now that this patch is good to go now > that space/tab formatting is fixed. Yes, the change is fine, please add my Acked-by: Arnd

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-14 Thread Josh Triplett
On Wed, Dec 14, 2016 at 10:11:19AM +0100, Arnd Bergmann wrote: > On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote: > > > > > > --- a/drivers/char/Kconfig > > > +++ b/drivers/char/Kconfig > > > @@ -589,10 +589,13 @@ config TELCLOCK > > > controlling the behavior of

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-14 Thread Josh Triplett
On Wed, Dec 14, 2016 at 10:11:19AM +0100, Arnd Bergmann wrote: > On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote: > > > > > > --- a/drivers/char/Kconfig > > > +++ b/drivers/char/Kconfig > > > @@ -589,10 +589,13 @@ config TELCLOCK > > > controlling the behavior of

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-14 Thread Arnd Bergmann
On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote: > > > > --- a/drivers/char/Kconfig > > +++ b/drivers/char/Kconfig > > @@ -589,10 +589,13 @@ config TELCLOCK > > controlling the behavior of this hardware. > > > > config DEVPORT > > - bool > > + bool

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-14 Thread Arnd Bergmann
On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote: > > > > --- a/drivers/char/Kconfig > > +++ b/drivers/char/Kconfig > > @@ -589,10 +589,13 @@ config TELCLOCK > > controlling the behavior of this hardware. > > > > config DEVPORT > > - bool > > + bool

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-14 Thread Geert Uytterhoeven
On Wed, Dec 14, 2016 at 2:18 AM, Max wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-14 Thread Geert Uytterhoeven
On Wed, Dec 14, 2016 at 2:18 AM, Max wrote: > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it (smaller kernel, attack

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-13 Thread Max
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-13 Thread Max
Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-13 Thread Greg KH
On Tue, Dec 13, 2016 at 04:32:25PM -0800, Max wrote: > From: Max Bires > > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may

Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-13 Thread Greg KH
On Tue, Dec 13, 2016 at 04:32:25PM -0800, Max wrote: > From: Max Bires > > Without a bool string present, using "# CONFIG_DEVPORT is not set" in > defconfig files would not actually unset devport. This ensured that > /dev/port was always on, but there are reasons a user may wish to disable > it

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-13 Thread Max
From: Max Bires Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if

[PATCH] char: lack of bool string made CONFIG_DEVPORT always on

2016-12-13 Thread Max
From: Max Bires Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This ensured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being