Re: [PATCH] char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol

On Sun, Mar 18, 2018 at 04:12:10PM +0100, Harald Welte wrote: > Hi Jia-Ju Bai, > > On Sun, Mar 18, 2018 at 10:49:57PM +0800, Jia-Ju Bai wrote: > > This is found by a static analysis tool named DCNS written by myself. > > nice catch! > > > Signed-off-by: Jia-Ju Bai > > Acked-by: Harald Welte

Re: [PATCH] char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol

On Sun, Mar 18, 2018 at 04:12:10PM +0100, Harald Welte wrote: > Hi Jia-Ju Bai, > > On Sun, Mar 18, 2018 at 10:49:57PM +0800, Jia-Ju Bai wrote: > > This is found by a static analysis tool named DCNS written by myself. > > nice catch! > > > Signed-off-by: Jia-Ju Bai > > Acked-by: Harald Welte

Re: [PATCH] char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol

Hi Jia-Ju Bai, On Sun, Mar 18, 2018 at 10:49:57PM +0800, Jia-Ju Bai wrote: > This is found by a static analysis tool named DCNS written by myself. nice catch! > Signed-off-by: Jia-Ju Bai Acked-by: Harald Welte -- - Harald Welte

Re: [PATCH] char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol

Hi Jia-Ju Bai, On Sun, Mar 18, 2018 at 10:49:57PM +0800, Jia-Ju Bai wrote: > This is found by a static analysis tool named DCNS written by myself. nice catch! > Signed-off-by: Jia-Ju Bai Acked-by: Harald Welte -- - Harald Weltehttp://laforge.gnumonks.org/

[PATCH] char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol

set_protocol() is never called in atomic context. The call chains ending up at set_protocol() are: [1] set_protocol() <- monitor_card() [2] set_protocol() <- cmm_ioctl() monitor_card() is only set in setup_timer(), and cmm_ioctl() is only set as ".unlocked_ioctl" in file_operations structure

[PATCH] char: pcmcia: cm4000_cs: Replace mdelay with usleep_range in set_protocol

set_protocol() is never called in atomic context. The call chains ending up at set_protocol() are: [1] set_protocol() <- monitor_card() [2] set_protocol() <- cmm_ioctl() monitor_card() is only set in setup_timer(), and cmm_ioctl() is only set as ".unlocked_ioctl" in file_operations structure