Re: [PATCH] checkpatch: Warn on bare unsigned or signed declarations without int

[David Miller]

From: Joe Perches 
Date: Fri,  4 Mar 2016 21:23:44 -0800

> Kernel style prefers "unsigned int " over "unsigned "
> and "signed int " over "signed ".
> 
> Emit a warning for these simple signed/unsigned  declarations.
> Fix it too if desired.
> 
> Signed-off-by: Joe Perches 

Acked-by: David S. Miller 

Re: [PATCH] checkpatch: Warn on bare unsigned or signed declarations without int

[David Miller]

From: Joe Perches 
Date: Fri,  4 Mar 2016 21:23:44 -0800

> Kernel style prefers "unsigned int " over "unsigned "
> and "signed int " over "signed ".
> 
> Emit a warning for these simple signed/unsigned  declarations.
> Fix it too if desired.
> 
> Signed-off-by: Joe Perches 

Acked-by: David S. Miller 

[PATCH] checkpatch: Warn on bare unsigned or signed declarations without int

[Joe Perches]

Kernel style prefers "unsigned int " over "unsigned "
and "signed int " over "signed ".

Emit a warning for these simple signed/unsigned  declarations.
Fix it too if desired.

Signed-off-by: Joe Perches 
---
 scripts/checkpatch.pl | 20 
 1 file changed, 20 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 874132b..c48b658 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3240,6 +3240,26 @@ sub process {
 #ignore lines not being added
next if ($line =~ /^[^\+]/);
 
+# check for declarations of signed or unsigned without int
+   while ($line =~ m{($Declare++)\s*($Ident)\s*[=,;\[\)]}g) {
+   my $type = $1;
+   my $var = $2;
+   if ($type =~ /^((?:un)?signed)((?:\s*\*)*)\s*$/) {
+   my $sign = $1;
+   my $pointer = $2;
+
+   $pointer = "" if (!defined $pointer);
+
+   if (WARN("UNSPECIFIED_INT",
+"Prefer '" . trim($sign) . " int" . 
rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . 
$herecurr) &&
+   $fix) {
+   my $decl = trim($sign) . " int ";
+   $decl .= trim($pointer) if 
(rtrim($pointer) ne "");
+   $fixed[$fixlinenr] =~ 
s@\b\Q$type\E\s*$var\b@$decl$var@;
+   }
+   }
+   }
+
 # TEST: allow direct testing of the type matcher.
if ($dbg_type) {
if ($line =~ /^.\s*$Declare\s*$/) {
-- 
2.6.3.368.gf34be46

[PATCH] checkpatch: Warn on bare unsigned or signed declarations without int

[Joe Perches]

Kernel style prefers "unsigned int " over "unsigned "
and "signed int " over "signed ".

Emit a warning for these simple signed/unsigned  declarations.
Fix it too if desired.

Signed-off-by: Joe Perches 
---
 scripts/checkpatch.pl | 20 
 1 file changed, 20 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 874132b..c48b658 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3240,6 +3240,26 @@ sub process {
 #ignore lines not being added
next if ($line =~ /^[^\+]/);
 
+# check for declarations of signed or unsigned without int
+   while ($line =~ m{($Declare++)\s*($Ident)\s*[=,;\[\)]}g) {
+   my $type = $1;
+   my $var = $2;
+   if ($type =~ /^((?:un)?signed)((?:\s*\*)*)\s*$/) {
+   my $sign = $1;
+   my $pointer = $2;
+
+   $pointer = "" if (!defined $pointer);
+
+   if (WARN("UNSPECIFIED_INT",
+"Prefer '" . trim($sign) . " int" . 
rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . 
$herecurr) &&
+   $fix) {
+   my $decl = trim($sign) . " int ";
+   $decl .= trim($pointer) if 
(rtrim($pointer) ne "");
+   $fixed[$fixlinenr] =~ 
s@\b\Q$type\E\s*$var\b@$decl$var@;
+   }
+   }
+   }
+
 # TEST: allow direct testing of the type matcher.
if ($dbg_type) {
if ($line =~ /^.\s*$Declare\s*$/) {
-- 
2.6.3.368.gf34be46