Re: [PATCH] checkpatch: improve handling of email comments

2020-10-31 Thread Dwaipayan Ray
Try this git log grep: $ git log --format=email -10 | \ grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \ grep -v 'stable\@' | \ grep -P '\>.+' This finds any signature/cc line with content after an email address that end with a close angle bracket that doesn't go to the stable

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-31 Thread Joe Perches
On Sat, 2020-10-31 at 11:41 +0530, Dwaipayan Ray wrote: > Names which have must quote characters without any comments are > not warned about right now: > > D. Ray doesn't throw any warning, while > D. Ray (Dwai) does. I agree that a comment in parentheses after the name and before the email

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-31 Thread Dwaipayan Ray
On Sat, Oct 31, 2020 at 9:44 AM Joe Perches wrote: > > On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote: > > > > On Fri, 30 Oct 2020, Joe Perches wrote: > > > > > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > > > > checkpatch has limited support for parsing email comments. It

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-30 Thread Joe Perches
On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote: > > On Fri, 30 Oct 2020, Joe Perches wrote: > > > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > > > checkpatch has limited support for parsing email comments. It only > > > support single name comments or single after address

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-30 Thread Joe Perches
On Fri, 2020-10-30 at 12:58 +0100, Lukas Bulwahn wrote: > On Fri, 30 Oct 2020, Joe Perches wrote: > > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > > > checkpatch has limited support for parsing email comments. It only > > > support single name comments or single after address

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-30 Thread Lukas Bulwahn
On Fri, 30 Oct 2020, Joe Perches wrote: > On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > > checkpatch has limited support for parsing email comments. It only > > support single name comments or single after address comments. > > Whereas, RFC 5322 specifies that comments can be

Re: [PATCH] checkpatch: improve handling of email comments

2020-10-30 Thread Joe Perches
On Fri, 2020-10-30 at 14:37 +0530, Dwaipayan Ray wrote: > checkpatch has limited support for parsing email comments. It only > support single name comments or single after address comments. > Whereas, RFC 5322 specifies that comments can be inserted in > between any tokens of the email fields. >

[PATCH] checkpatch: improve handling of email comments

2020-10-30 Thread Dwaipayan Ray
checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields. Improve comment parsing mechanism in checkpatch. What is handled