[PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Igor Stoppa
The checkpatch.pl script complains when the help section of a Kconfig entry is too short, but it doesn't really explain what it is looking for. Instead, it gives a generic warning that one should consider writing a paragraph. But what it *really* checks is that the help section is at least

Re: [PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Andi Kleen
>"expecting a 'help' section of > $min_conf_desc_length or more lines\n" . $herecurr); > or maybe >"please write a paragraph that describes > the config symbol fully ($min_conf_desc_length or more lines)\n" . $herecurr); >

Re: [PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Joe Perches
On Wed, 2018-12-19 at 20:55 +0200, Igor Stoppa wrote: > The checkpatch.pl script complains when the help section of a Kconfig > entry is too short, but it doesn't really explain what it is looking > for. Instead, it gives a generic warning that one should consider writing > a paragraph. > > But

[PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Igor Stoppa
The checkpatch.pl script complains when the help section of a Kconfig entry is too short, but it doesn't really explain what it is looking for. Instead, it gives a generic warning that one should consider writing a paragraph. But what it *really* checks is that the help section is at least

Re: [PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Igor Stoppa
On 19/12/2018 14:29, Joe Perches wrote: On Wed, 2018-12-19 at 11:59 +, Andy Whitcroft wrote: On Wed, Dec 19, 2018 at 02:44:36AM -0800, Joe Perches wrote: To cover both cases perhaps: "please ensure that this config symbols is described fully (less than

Re: [PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Joe Perches
On Wed, 2018-12-19 at 11:59 +, Andy Whitcroft wrote: > On Wed, Dec 19, 2018 at 02:44:36AM -0800, Joe Perches wrote: > > On Wed, 2018-12-19 at 10:35 +0200, Igor Stoppa wrote: > > > The checkpatch.pl script complains when the help section of a Kconfig > > > entry is too short, but it doesn't

Re: [PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Andy Whitcroft
On Wed, Dec 19, 2018 at 02:44:36AM -0800, Joe Perches wrote: > On Wed, 2018-12-19 at 10:35 +0200, Igor Stoppa wrote: > > The checkpatch.pl script complains when the help section of a Kconfig > > entry is too short, but it doesn't really explain what it is looking > > for. Instead, it gives a

Re: [PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Joe Perches
On Wed, 2018-12-19 at 10:35 +0200, Igor Stoppa wrote: > The checkpatch.pl script complains when the help section of a Kconfig > entry is too short, but it doesn't really explain what it is looking > for. Instead, it gives a generic warning that one should consider writing > a paragraph. > > But

[PATCH] checkpatch.pl: Improve WARNING on Kconfig help

2018-12-19 Thread Igor Stoppa
The checkpatch.pl script complains when the help section of a Kconfig entry is too short, but it doesn't really explain what it is looking for. Instead, it gives a generic warning that one should consider writing a paragraph. But what it *really* checks is that the help section is at least