Re: [PATCH] cifs: Fix bool initialization/comparison

2017-10-09 Thread Nico Kadel-Garcia
On Sat, Oct 7, 2017 at 10:02 AM, Thomas Meyer via samba-technical wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. Except that "==" is not a pure boolean check. It's a value check, and unless these values are defined

Re: [PATCH] cifs: Fix bool initialization/comparison

2017-10-09 Thread Nico Kadel-Garcia
On Sat, Oct 7, 2017 at 10:02 AM, Thomas Meyer via samba-technical wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. Except that "==" is not a pure boolean check. It's a value check, and unless these values are defined *very* carefully they may be set

[PATCH] cifs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c --- a/fs/cifs/cifsacl.c +++ b/fs/cifs/cifsacl.c @@ -370,7 +370,7 @@ sid_to_id(struct cifs_sb_info *cifs_sb,

[PATCH] cifs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c --- a/fs/cifs/cifsacl.c +++ b/fs/cifs/cifsacl.c @@ -370,7 +370,7 @@ sid_to_id(struct cifs_sb_info *cifs_sb, else