Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Gregory CLEMENT
On 04/12/2013 11:12 AM, Christian Ruppert wrote: > On Fri, Apr 12, 2013 at 11:04:51AM +0200, Gregory CLEMENT wrote: >> On 04/12/2013 08:54 AM, Christian Ruppert wrote: >>> On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: On 04/11/2013 11:19 AM, Christian Ruppert wrote: >

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Christian Ruppert
On Fri, Apr 12, 2013 at 11:04:51AM +0200, Gregory CLEMENT wrote: > On 04/12/2013 08:54 AM, Christian Ruppert wrote: > > On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: > >> On 04/11/2013 11:19 AM, Christian Ruppert wrote: > >>> Hi Gregory, > >>> > >>> Since there doesn't seem to

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Gregory CLEMENT
On 04/12/2013 08:54 AM, Christian Ruppert wrote: > On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: >> On 04/11/2013 11:19 AM, Christian Ruppert wrote: >>> Hi Gregory, >>> >>> Since there doesn't seem to be anyone opposing this feature I just >>> checked your patch and after adding

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Gregory CLEMENT
On 04/12/2013 08:54 AM, Christian Ruppert wrote: > On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: >> On 04/11/2013 11:19 AM, Christian Ruppert wrote: >>> Hi Gregory, >>> >>> Since there doesn't seem to be anyone opposing this feature I just >>> checked your patch and after adding

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Christian Ruppert
On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: > On 04/11/2013 11:19 AM, Christian Ruppert wrote: > > Hi Gregory, > > > > Since there doesn't seem to be anyone opposing this feature I just > > checked your patch and after adding the CLK_OF_DECLARE macro in the end > > it works

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Christian Ruppert
On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: On 04/11/2013 11:19 AM, Christian Ruppert wrote: Hi Gregory, Since there doesn't seem to be anyone opposing this feature I just checked your patch and after adding the CLK_OF_DECLARE macro in the end it works well for us.

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Gregory CLEMENT
On 04/12/2013 08:54 AM, Christian Ruppert wrote: On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: On 04/11/2013 11:19 AM, Christian Ruppert wrote: Hi Gregory, Since there doesn't seem to be anyone opposing this feature I just checked your patch and after adding the

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Gregory CLEMENT
On 04/12/2013 08:54 AM, Christian Ruppert wrote: On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: On 04/11/2013 11:19 AM, Christian Ruppert wrote: Hi Gregory, Since there doesn't seem to be anyone opposing this feature I just checked your patch and after adding the

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Christian Ruppert
On Fri, Apr 12, 2013 at 11:04:51AM +0200, Gregory CLEMENT wrote: On 04/12/2013 08:54 AM, Christian Ruppert wrote: On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: On 04/11/2013 11:19 AM, Christian Ruppert wrote: Hi Gregory, Since there doesn't seem to be anyone opposing

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-12 Thread Gregory CLEMENT
On 04/12/2013 11:12 AM, Christian Ruppert wrote: On Fri, Apr 12, 2013 at 11:04:51AM +0200, Gregory CLEMENT wrote: On 04/12/2013 08:54 AM, Christian Ruppert wrote: On Thu, Apr 11, 2013 at 06:26:07PM +0200, Gregory CLEMENT wrote: On 04/11/2013 11:19 AM, Christian Ruppert wrote: Hi Gregory,

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-11 Thread Gregory CLEMENT
On 04/11/2013 11:19 AM, Christian Ruppert wrote: > Hi Gregory, > > Since there doesn't seem to be anyone opposing this feature I just > checked your patch and after adding the CLK_OF_DECLARE macro in the end > it works well for us. Tell me if you would like to rebase and resubmit > your patch or

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-11 Thread Christian Ruppert
Hi Gregory, Since there doesn't seem to be anyone opposing this feature I just checked your patch and after adding the CLK_OF_DECLARE macro in the end it works well for us. Tell me if you would like to rebase and resubmit your patch or if I should follow up on our own. Greetings, Christian On

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-11 Thread Christian Ruppert
Hi Gregory, Since there doesn't seem to be anyone opposing this feature I just checked your patch and after adding the CLK_OF_DECLARE macro in the end it works well for us. Tell me if you would like to rebase and resubmit your patch or if I should follow up on our own. Greetings, Christian On

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-11 Thread Gregory CLEMENT
On 04/11/2013 11:19 AM, Christian Ruppert wrote: Hi Gregory, Since there doesn't seem to be anyone opposing this feature I just checked your patch and after adding the CLK_OF_DECLARE macro in the end it works well for us. Tell me if you would like to rebase and resubmit your patch or if I

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-10 Thread Christian Ruppert
Hi Gregory, We use derived clocks with fixed ratios for our TB10x platform. I originally had this in the platform code but Vineet (the platform maintainer) rightly pointed out that the common clock framework would be the correct place for it. Is there any reason not to support this functionality?

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-10 Thread Gregory CLEMENT
Hi Christian, On 04/10/2013 05:40 PM, Christian Ruppert wrote: > This patch adds a device tree binding for the simple fixed factor clock > divider/multiplier of the common clock tree binding. This patch remind me of something :

[PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-10 Thread Christian Ruppert
This patch adds a device tree binding for the simple fixed factor clock divider/multiplier of the common clock tree binding. Signed-off-by: Christian Ruppert --- .../bindings/clock/fixed-factor-clkdiv.txt | 24 +++ drivers/clk/clk-fixed-factor.c | 32

[PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-10 Thread Christian Ruppert
This patch adds a device tree binding for the simple fixed factor clock divider/multiplier of the common clock tree binding. Signed-off-by: Christian Ruppert christian.rupp...@abilis.com --- .../bindings/clock/fixed-factor-clkdiv.txt | 24 +++ drivers/clk/clk-fixed-factor.c

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-10 Thread Gregory CLEMENT
Hi Christian, On 04/10/2013 05:40 PM, Christian Ruppert wrote: This patch adds a device tree binding for the simple fixed factor clock divider/multiplier of the common clock tree binding. This patch remind me of something :

Re: [PATCH] clk: Add device tree binding to clk-fixed-factor

2013-04-10 Thread Christian Ruppert
Hi Gregory, We use derived clocks with fixed ratios for our TB10x platform. I originally had this in the platform code but Vineet (the platform maintainer) rightly pointed out that the common clock framework would be the correct place for it. Is there any reason not to support this functionality?