Re: [PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Stephen Boyd
On 01/02, Geert Uytterhoeven wrote: > On Tue, Jan 2, 2018 at 8:23 PM, Stephen Boyd wrote: > > On 01/02, Geert Uytterhoeven wrote: > >> --- a/drivers/clk/clk.c > >> +++ b/drivers/clk/clk.c > >> @@ -58,7 +58,7 @@ struct clk_core { > >> unsigned long new_rate;

Re: [PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Stephen Boyd
On 01/02, Geert Uytterhoeven wrote: > On Tue, Jan 2, 2018 at 8:23 PM, Stephen Boyd wrote: > > On 01/02, Geert Uytterhoeven wrote: > >> --- a/drivers/clk/clk.c > >> +++ b/drivers/clk/clk.c > >> @@ -58,7 +58,7 @@ struct clk_core { > >> unsigned long new_rate; > >> struct

Re: [PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Geert Uytterhoeven
Hi Stephen, On Tue, Jan 2, 2018 at 8:23 PM, Stephen Boyd wrote: > On 01/02, Geert Uytterhoeven wrote: >> When exposing data access through debugfs, the correct >> debugfs_create_*() functions must be used, depending on data type. >> >> Remove all casts from data pointers

Re: [PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Geert Uytterhoeven
Hi Stephen, On Tue, Jan 2, 2018 at 8:23 PM, Stephen Boyd wrote: > On 01/02, Geert Uytterhoeven wrote: >> When exposing data access through debugfs, the correct >> debugfs_create_*() functions must be used, depending on data type. >> >> Remove all casts from data pointers passed to

Re: [PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Stephen Boyd
On 01/02, Geert Uytterhoeven wrote: > When exposing data access through debugfs, the correct > debugfs_create_*() functions must be used, depending on data type. > > Remove all casts from data pointers passed to debugfs_create_*() > functions, as such casts prevent the compiler from flagging

Re: [PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Stephen Boyd
On 01/02, Geert Uytterhoeven wrote: > When exposing data access through debugfs, the correct > debugfs_create_*() functions must be used, depending on data type. > > Remove all casts from data pointers passed to debugfs_create_*() > functions, as such casts prevent the compiler from flagging

[PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Geert Uytterhoeven
When exposing data access through debugfs, the correct debugfs_create_*() functions must be used, depending on data type. Remove all casts from data pointers passed to debugfs_create_*() functions, as such casts prevent the compiler from flagging bugs. clk_core.rate, .accuracy, and .flags are

[PATCH] clk: Fix debugfs_create_*() usage

2018-01-02 Thread Geert Uytterhoeven
When exposing data access through debugfs, the correct debugfs_create_*() functions must be used, depending on data type. Remove all casts from data pointers passed to debugfs_create_*() functions, as such casts prevent the compiler from flagging bugs. clk_core.rate, .accuracy, and .flags are