Re: [PATCH] clk: qcom: Move to menuconfig and reduce lines
Hi Stephen, I love your patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.20-rc3 next-20181122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/clk-qcom-Move-to-menuconfig-and-reduce-lines/20181123-061930 base: https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git for-next config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> drivers/clk/qcom/clk-krait.c:13:10: fatal error: asm/krait-l2-accessors.h: >> No such file or directory #include ^~ compilation terminated. vim +13 drivers/clk/qcom/clk-krait.c 4d7dc77b Stephen Boyd 2018-08-14 12 4d7dc77b Stephen Boyd 2018-08-14 @13 #include 4d7dc77b Stephen Boyd 2018-08-14 14 :: The code at line 13 was first introduced by commit :: 4d7dc77babfef1d6cb8fd825e2f17dc3384c3272 clk: qcom: Add support for Krait clocks :: TO: Stephen Boyd :: CC: Stephen Boyd --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] clk: qcom: Move to menuconfig and reduce lines
Hi Stephen, I love your patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.20-rc3 next-20181122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/clk-qcom-Move-to-menuconfig-and-reduce-lines/20181123-061930 base: https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git for-next config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> drivers/clk/qcom/clk-krait.c:13:10: fatal error: asm/krait-l2-accessors.h: >> No such file or directory #include ^~ compilation terminated. vim +13 drivers/clk/qcom/clk-krait.c 4d7dc77b Stephen Boyd 2018-08-14 12 4d7dc77b Stephen Boyd 2018-08-14 @13 #include 4d7dc77b Stephen Boyd 2018-08-14 14 :: The code at line 13 was first introduced by commit :: 4d7dc77babfef1d6cb8fd825e2f17dc3384c3272 clk: qcom: Add support for Krait clocks :: TO: Stephen Boyd :: CC: Stephen Boyd --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] clk: qcom: Move to menuconfig and reduce lines
On Wed 21 Nov 13:01 PST 2018, Stephen Boyd wrote: > We duplicate the 'depends on' in almost every Kconfig here, and it's > getting out of hand now that we have tens of options for various SoC > drivers here. Let's clean it up a little by making a menuconfig for a > submenu and adding an if wrapper around the driver section. > > Cc: Taniya Das > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/clk/qcom/Kconfig | 39 +-- > 1 file changed, 5 insertions(+), 34 deletions(-) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index a611531df115..1977f40f4bec 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -9,16 +9,17 @@ config QCOM_GDSC > config QCOM_RPMCC > bool > > -config COMMON_CLK_QCOM > +menuconfig COMMON_CLK_QCOM > tristate "Support for Qualcomm's clock controllers" > depends on OF > depends on ARCH_QCOM || COMPILE_TEST > select REGMAP_MMIO > select RESET_CONTROLLER > > +if COMMON_CLK_QCOM > + > config QCOM_A53PLL > tristate "MSM8916 A53 PLL" > - depends on COMMON_CLK_QCOM > default ARCH_QCOM > help > Support for the A53 PLL on MSM8916 devices. It provides > @@ -28,7 +29,6 @@ config QCOM_A53PLL > > config QCOM_CLK_APCS_MSM8916 > tristate "MSM8916 APCS Clock Controller" > - depends on COMMON_CLK_QCOM > depends on QCOM_APCS_IPC || COMPILE_TEST > default ARCH_QCOM > help > @@ -39,7 +39,6 @@ config QCOM_CLK_APCS_MSM8916 > > config QCOM_CLK_RPM > tristate "RPM based Clock Controller" > - depends on COMMON_CLK_QCOM && MFD_QCOM_RPM > select QCOM_RPMCC > help > The RPM (Resource Power Manager) is a dedicated hardware engine for > @@ -52,7 +51,6 @@ config QCOM_CLK_RPM > > config QCOM_CLK_SMD_RPM > tristate "RPM over SMD based Clock Controller" > - depends on COMMON_CLK_QCOM && QCOM_SMD_RPM > select QCOM_RPMCC > help > The RPM (Resource Power Manager) is a dedicated hardware engine for > @@ -65,7 +63,6 @@ config QCOM_CLK_SMD_RPM > > config QCOM_CLK_RPMH > tristate "RPMh Clock Driver" > - depends on COMMON_CLK_QCOM && QCOM_RPMH > help >RPMh manages shared resources on some Qualcomm Technologies, Inc. >SoCs. It accepts requests from other hardware subsystems via RSC. > @@ -75,7 +72,6 @@ config QCOM_CLK_RPMH > config APQ_GCC_8084 > tristate "APQ8084 Global Clock Controller" > select QCOM_GDSC > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on apq8084 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -85,7 +81,6 @@ config APQ_MMCC_8084 > tristate "APQ8084 Multimedia Clock Controller" > select APQ_GCC_8084 > select QCOM_GDSC > - depends on COMMON_CLK_QCOM > help > Support for the multimedia clock controller on apq8084 devices. > Say Y if you want to support multimedia devices such as display, > @@ -93,7 +88,6 @@ config APQ_MMCC_8084 > > config IPQ_GCC_4019 > tristate "IPQ4019 Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on ipq4019 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -101,7 +95,6 @@ config IPQ_GCC_4019 > > config IPQ_GCC_806X > tristate "IPQ806x Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on ipq806x devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -110,7 +103,6 @@ config IPQ_GCC_806X > config IPQ_LCC_806X > tristate "IPQ806x LPASS Clock Controller" > select IPQ_GCC_806X > - depends on COMMON_CLK_QCOM > help > Support for the LPASS clock controller on ipq806x devices. > Say Y if you want to use audio devices such as i2s, pcm, > @@ -118,7 +110,6 @@ config IPQ_LCC_806X > > config IPQ_GCC_8074 > tristate "IPQ8074 Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for global clock controller on ipq8074 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -127,7 +118,6 @@ config IPQ_GCC_8074 > > config MSM_GCC_8660 > tristate "MSM8660 Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on msm8660 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -136,7 +126,6 @@ config MSM_GCC_8660 > config MSM_GCC_8916 > tristate "MSM8916 Global Clock Controller" > select QCOM_GDSC > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on msm8916 devices. > Say Y if you want to use devices such as UART, SPI i2c,
Re: [PATCH] clk: qcom: Move to menuconfig and reduce lines
On Wed 21 Nov 13:01 PST 2018, Stephen Boyd wrote: > We duplicate the 'depends on' in almost every Kconfig here, and it's > getting out of hand now that we have tens of options for various SoC > drivers here. Let's clean it up a little by making a menuconfig for a > submenu and adding an if wrapper around the driver section. > > Cc: Taniya Das > Signed-off-by: Stephen Boyd Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/clk/qcom/Kconfig | 39 +-- > 1 file changed, 5 insertions(+), 34 deletions(-) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index a611531df115..1977f40f4bec 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -9,16 +9,17 @@ config QCOM_GDSC > config QCOM_RPMCC > bool > > -config COMMON_CLK_QCOM > +menuconfig COMMON_CLK_QCOM > tristate "Support for Qualcomm's clock controllers" > depends on OF > depends on ARCH_QCOM || COMPILE_TEST > select REGMAP_MMIO > select RESET_CONTROLLER > > +if COMMON_CLK_QCOM > + > config QCOM_A53PLL > tristate "MSM8916 A53 PLL" > - depends on COMMON_CLK_QCOM > default ARCH_QCOM > help > Support for the A53 PLL on MSM8916 devices. It provides > @@ -28,7 +29,6 @@ config QCOM_A53PLL > > config QCOM_CLK_APCS_MSM8916 > tristate "MSM8916 APCS Clock Controller" > - depends on COMMON_CLK_QCOM > depends on QCOM_APCS_IPC || COMPILE_TEST > default ARCH_QCOM > help > @@ -39,7 +39,6 @@ config QCOM_CLK_APCS_MSM8916 > > config QCOM_CLK_RPM > tristate "RPM based Clock Controller" > - depends on COMMON_CLK_QCOM && MFD_QCOM_RPM > select QCOM_RPMCC > help > The RPM (Resource Power Manager) is a dedicated hardware engine for > @@ -52,7 +51,6 @@ config QCOM_CLK_RPM > > config QCOM_CLK_SMD_RPM > tristate "RPM over SMD based Clock Controller" > - depends on COMMON_CLK_QCOM && QCOM_SMD_RPM > select QCOM_RPMCC > help > The RPM (Resource Power Manager) is a dedicated hardware engine for > @@ -65,7 +63,6 @@ config QCOM_CLK_SMD_RPM > > config QCOM_CLK_RPMH > tristate "RPMh Clock Driver" > - depends on COMMON_CLK_QCOM && QCOM_RPMH > help >RPMh manages shared resources on some Qualcomm Technologies, Inc. >SoCs. It accepts requests from other hardware subsystems via RSC. > @@ -75,7 +72,6 @@ config QCOM_CLK_RPMH > config APQ_GCC_8084 > tristate "APQ8084 Global Clock Controller" > select QCOM_GDSC > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on apq8084 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -85,7 +81,6 @@ config APQ_MMCC_8084 > tristate "APQ8084 Multimedia Clock Controller" > select APQ_GCC_8084 > select QCOM_GDSC > - depends on COMMON_CLK_QCOM > help > Support for the multimedia clock controller on apq8084 devices. > Say Y if you want to support multimedia devices such as display, > @@ -93,7 +88,6 @@ config APQ_MMCC_8084 > > config IPQ_GCC_4019 > tristate "IPQ4019 Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on ipq4019 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -101,7 +95,6 @@ config IPQ_GCC_4019 > > config IPQ_GCC_806X > tristate "IPQ806x Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on ipq806x devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -110,7 +103,6 @@ config IPQ_GCC_806X > config IPQ_LCC_806X > tristate "IPQ806x LPASS Clock Controller" > select IPQ_GCC_806X > - depends on COMMON_CLK_QCOM > help > Support for the LPASS clock controller on ipq806x devices. > Say Y if you want to use audio devices such as i2s, pcm, > @@ -118,7 +110,6 @@ config IPQ_LCC_806X > > config IPQ_GCC_8074 > tristate "IPQ8074 Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for global clock controller on ipq8074 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -127,7 +118,6 @@ config IPQ_GCC_8074 > > config MSM_GCC_8660 > tristate "MSM8660 Global Clock Controller" > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on msm8660 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > @@ -136,7 +126,6 @@ config MSM_GCC_8660 > config MSM_GCC_8916 > tristate "MSM8916 Global Clock Controller" > select QCOM_GDSC > - depends on COMMON_CLK_QCOM > help > Support for the global clock controller on msm8916 devices. > Say Y if you want to use devices such as UART, SPI i2c,
[PATCH] clk: qcom: Move to menuconfig and reduce lines
We duplicate the 'depends on' in almost every Kconfig here, and it's getting out of hand now that we have tens of options for various SoC drivers here. Let's clean it up a little by making a menuconfig for a submenu and adding an if wrapper around the driver section. Cc: Taniya Das Signed-off-by: Stephen Boyd --- drivers/clk/qcom/Kconfig | 39 +-- 1 file changed, 5 insertions(+), 34 deletions(-) diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index a611531df115..1977f40f4bec 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -9,16 +9,17 @@ config QCOM_GDSC config QCOM_RPMCC bool -config COMMON_CLK_QCOM +menuconfig COMMON_CLK_QCOM tristate "Support for Qualcomm's clock controllers" depends on OF depends on ARCH_QCOM || COMPILE_TEST select REGMAP_MMIO select RESET_CONTROLLER +if COMMON_CLK_QCOM + config QCOM_A53PLL tristate "MSM8916 A53 PLL" - depends on COMMON_CLK_QCOM default ARCH_QCOM help Support for the A53 PLL on MSM8916 devices. It provides @@ -28,7 +29,6 @@ config QCOM_A53PLL config QCOM_CLK_APCS_MSM8916 tristate "MSM8916 APCS Clock Controller" - depends on COMMON_CLK_QCOM depends on QCOM_APCS_IPC || COMPILE_TEST default ARCH_QCOM help @@ -39,7 +39,6 @@ config QCOM_CLK_APCS_MSM8916 config QCOM_CLK_RPM tristate "RPM based Clock Controller" - depends on COMMON_CLK_QCOM && MFD_QCOM_RPM select QCOM_RPMCC help The RPM (Resource Power Manager) is a dedicated hardware engine for @@ -52,7 +51,6 @@ config QCOM_CLK_RPM config QCOM_CLK_SMD_RPM tristate "RPM over SMD based Clock Controller" - depends on COMMON_CLK_QCOM && QCOM_SMD_RPM select QCOM_RPMCC help The RPM (Resource Power Manager) is a dedicated hardware engine for @@ -65,7 +63,6 @@ config QCOM_CLK_SMD_RPM config QCOM_CLK_RPMH tristate "RPMh Clock Driver" - depends on COMMON_CLK_QCOM && QCOM_RPMH help RPMh manages shared resources on some Qualcomm Technologies, Inc. SoCs. It accepts requests from other hardware subsystems via RSC. @@ -75,7 +72,6 @@ config QCOM_CLK_RPMH config APQ_GCC_8084 tristate "APQ8084 Global Clock Controller" select QCOM_GDSC - depends on COMMON_CLK_QCOM help Support for the global clock controller on apq8084 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -85,7 +81,6 @@ config APQ_MMCC_8084 tristate "APQ8084 Multimedia Clock Controller" select APQ_GCC_8084 select QCOM_GDSC - depends on COMMON_CLK_QCOM help Support for the multimedia clock controller on apq8084 devices. Say Y if you want to support multimedia devices such as display, @@ -93,7 +88,6 @@ config APQ_MMCC_8084 config IPQ_GCC_4019 tristate "IPQ4019 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global clock controller on ipq4019 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -101,7 +95,6 @@ config IPQ_GCC_4019 config IPQ_GCC_806X tristate "IPQ806x Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global clock controller on ipq806x devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -110,7 +103,6 @@ config IPQ_GCC_806X config IPQ_LCC_806X tristate "IPQ806x LPASS Clock Controller" select IPQ_GCC_806X - depends on COMMON_CLK_QCOM help Support for the LPASS clock controller on ipq806x devices. Say Y if you want to use audio devices such as i2s, pcm, @@ -118,7 +110,6 @@ config IPQ_LCC_806X config IPQ_GCC_8074 tristate "IPQ8074 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for global clock controller on ipq8074 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -127,7 +118,6 @@ config IPQ_GCC_8074 config MSM_GCC_8660 tristate "MSM8660 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global clock controller on msm8660 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -136,7 +126,6 @@ config MSM_GCC_8660 config MSM_GCC_8916 tristate "MSM8916 Global Clock Controller" select QCOM_GDSC - depends on COMMON_CLK_QCOM help Support for the global clock controller on msm8916 devices. Say Y if you want to use devices such as UART, SPI i2c, USB, @@ -144,7 +133,6 @@ config MSM_GCC_8916 config MSM_GCC_8960 tristate "APQ8064/MSM8960 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global
[PATCH] clk: qcom: Move to menuconfig and reduce lines
We duplicate the 'depends on' in almost every Kconfig here, and it's getting out of hand now that we have tens of options for various SoC drivers here. Let's clean it up a little by making a menuconfig for a submenu and adding an if wrapper around the driver section. Cc: Taniya Das Signed-off-by: Stephen Boyd --- drivers/clk/qcom/Kconfig | 39 +-- 1 file changed, 5 insertions(+), 34 deletions(-) diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index a611531df115..1977f40f4bec 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -9,16 +9,17 @@ config QCOM_GDSC config QCOM_RPMCC bool -config COMMON_CLK_QCOM +menuconfig COMMON_CLK_QCOM tristate "Support for Qualcomm's clock controllers" depends on OF depends on ARCH_QCOM || COMPILE_TEST select REGMAP_MMIO select RESET_CONTROLLER +if COMMON_CLK_QCOM + config QCOM_A53PLL tristate "MSM8916 A53 PLL" - depends on COMMON_CLK_QCOM default ARCH_QCOM help Support for the A53 PLL on MSM8916 devices. It provides @@ -28,7 +29,6 @@ config QCOM_A53PLL config QCOM_CLK_APCS_MSM8916 tristate "MSM8916 APCS Clock Controller" - depends on COMMON_CLK_QCOM depends on QCOM_APCS_IPC || COMPILE_TEST default ARCH_QCOM help @@ -39,7 +39,6 @@ config QCOM_CLK_APCS_MSM8916 config QCOM_CLK_RPM tristate "RPM based Clock Controller" - depends on COMMON_CLK_QCOM && MFD_QCOM_RPM select QCOM_RPMCC help The RPM (Resource Power Manager) is a dedicated hardware engine for @@ -52,7 +51,6 @@ config QCOM_CLK_RPM config QCOM_CLK_SMD_RPM tristate "RPM over SMD based Clock Controller" - depends on COMMON_CLK_QCOM && QCOM_SMD_RPM select QCOM_RPMCC help The RPM (Resource Power Manager) is a dedicated hardware engine for @@ -65,7 +63,6 @@ config QCOM_CLK_SMD_RPM config QCOM_CLK_RPMH tristate "RPMh Clock Driver" - depends on COMMON_CLK_QCOM && QCOM_RPMH help RPMh manages shared resources on some Qualcomm Technologies, Inc. SoCs. It accepts requests from other hardware subsystems via RSC. @@ -75,7 +72,6 @@ config QCOM_CLK_RPMH config APQ_GCC_8084 tristate "APQ8084 Global Clock Controller" select QCOM_GDSC - depends on COMMON_CLK_QCOM help Support for the global clock controller on apq8084 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -85,7 +81,6 @@ config APQ_MMCC_8084 tristate "APQ8084 Multimedia Clock Controller" select APQ_GCC_8084 select QCOM_GDSC - depends on COMMON_CLK_QCOM help Support for the multimedia clock controller on apq8084 devices. Say Y if you want to support multimedia devices such as display, @@ -93,7 +88,6 @@ config APQ_MMCC_8084 config IPQ_GCC_4019 tristate "IPQ4019 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global clock controller on ipq4019 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -101,7 +95,6 @@ config IPQ_GCC_4019 config IPQ_GCC_806X tristate "IPQ806x Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global clock controller on ipq806x devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -110,7 +103,6 @@ config IPQ_GCC_806X config IPQ_LCC_806X tristate "IPQ806x LPASS Clock Controller" select IPQ_GCC_806X - depends on COMMON_CLK_QCOM help Support for the LPASS clock controller on ipq806x devices. Say Y if you want to use audio devices such as i2s, pcm, @@ -118,7 +110,6 @@ config IPQ_LCC_806X config IPQ_GCC_8074 tristate "IPQ8074 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for global clock controller on ipq8074 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -127,7 +118,6 @@ config IPQ_GCC_8074 config MSM_GCC_8660 tristate "MSM8660 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global clock controller on msm8660 devices. Say Y if you want to use peripheral devices such as UART, SPI, @@ -136,7 +126,6 @@ config MSM_GCC_8660 config MSM_GCC_8916 tristate "MSM8916 Global Clock Controller" select QCOM_GDSC - depends on COMMON_CLK_QCOM help Support for the global clock controller on msm8916 devices. Say Y if you want to use devices such as UART, SPI i2c, USB, @@ -144,7 +133,6 @@ config MSM_GCC_8916 config MSM_GCC_8960 tristate "APQ8064/MSM8960 Global Clock Controller" - depends on COMMON_CLK_QCOM help Support for the global
