Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Boris BREZILLON
Hi Sylwester, Le 27/03/2014 11:01, Sylwester Nawrocki a écrit : Hi Boris, On 27/03/14 08:58, Boris BREZILLON wrote: This solution solve the problem for this specific case because clks are declared in the correct order in imx DTs. But, even with your patch I think we could see similar issues

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Sylwester Nawrocki
Mike, please ignore this patch for now. It turns out a less intrusive change [1] is enough to fix the regressions on both imx and exynos. I'm going to address the issue properly for next kernel release and make exynos use regular fixed-clock driver, rather than registering the external clock

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Sylwester Nawrocki
Hi Boris, On 27/03/14 08:58, Boris BREZILLON wrote: > This solution solve the problem for this specific case because clks are > declared in the correct order in imx DTs. > But, even with your patch I think we could see similar issues by > reordering DT nodes... > > The real problem here is that

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Boris BREZILLON
Le 26/03/2014 21:14, Fabio Estevam a écrit : On Wed, Mar 26, 2014 at 4:57 PM, Sylwester Nawrocki wrote: Perhaps a change as below helps ? From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 From: Sylwester Nawrocki Date: Wed, 26 Mar 2014 20:54:13 +0100 Subject: [PATCH]

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Boris BREZILLON
Le 26/03/2014 21:14, Fabio Estevam a écrit : On Wed, Mar 26, 2014 at 4:57 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Perhaps a change as below helps ? From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 From: Sylwester Nawrocki s.nawro...@samsung.com Date:

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Sylwester Nawrocki
Hi Boris, On 27/03/14 08:58, Boris BREZILLON wrote: This solution solve the problem for this specific case because clks are declared in the correct order in imx DTs. But, even with your patch I think we could see similar issues by reordering DT nodes... The real problem here is that imx

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Sylwester Nawrocki
Mike, please ignore this patch for now. It turns out a less intrusive change [1] is enough to fix the regressions on both imx and exynos. I'm going to address the issue properly for next kernel release and make exynos use regular fixed-clock driver, rather than registering the external clock

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-27 Thread Boris BREZILLON
Hi Sylwester, Le 27/03/2014 11:01, Sylwester Nawrocki a écrit : Hi Boris, On 27/03/14 08:58, Boris BREZILLON wrote: This solution solve the problem for this specific case because clks are declared in the correct order in imx DTs. But, even with your patch I think we could see similar issues

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Fabio Estevam
On Wed, Mar 26, 2014 at 5:25 PM, Gregory CLEMENT wrote: > However, Fabio, could you apply the following patch without the patch > "clk: reverse default clk provider initialization order in > of_clk_init()" and then sent me the traces. I would like to be sure > that there is not any side effect.

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Gregory CLEMENT
On 26/03/2014 21:14, Fabio Estevam wrote: > On Wed, Mar 26, 2014 at 4:57 PM, Sylwester Nawrocki > wrote: > >> Perhaps a change as below helps ? >> >> From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 >> From: Sylwester Nawrocki >> Date: Wed, 26 Mar 2014 20:54:13 +0100 >>

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Fabio Estevam
On Wed, Mar 26, 2014 at 4:57 PM, Sylwester Nawrocki wrote: > Perhaps a change as below helps ? > > From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 > From: Sylwester Nawrocki > Date: Wed, 26 Mar 2014 20:54:13 +0100 > Subject: [PATCH] clk: reverse default clk provider

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Sylwester Nawrocki
Hi Fabio, On 03/26/2014 07:33 PM, Fabio Estevam wrote: On Wed, Mar 26, 2014 at 3:22 PM, Sylwester Nawrocki wrote: [...] Still not able to boot with this patch applied: Perhaps a change as below helps ? From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 From: Sylwester

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Fabio Estevam
Hi Sylwester, On Wed, Mar 26, 2014 at 3:22 PM, Sylwester Nawrocki wrote: > After commit 1771b10d605d26ccee771a7fb4b08718c124097a > "clk: respect the clock dependencies in of_clk_init" > the order of registering clock providers and their corresponding > clocks may change. This commit currently

[PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Sylwester Nawrocki
After commit 1771b10d605d26ccee771a7fb4b08718c124097a "clk: respect the clock dependencies in of_clk_init" the order of registering clock providers and their corresponding clocks may change. This commit currently causes a regression on Exynos4 platforms, where fixed clocks are now being registered

[PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Sylwester Nawrocki
After commit 1771b10d605d26ccee771a7fb4b08718c124097a clk: respect the clock dependencies in of_clk_init the order of registering clock providers and their corresponding clocks may change. This commit currently causes a regression on Exynos4 platforms, where fixed clocks are now being registered

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Fabio Estevam
Hi Sylwester, On Wed, Mar 26, 2014 at 3:22 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: After commit 1771b10d605d26ccee771a7fb4b08718c124097a clk: respect the clock dependencies in of_clk_init the order of registering clock providers and their corresponding clocks may change. This

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Sylwester Nawrocki
Hi Fabio, On 03/26/2014 07:33 PM, Fabio Estevam wrote: On Wed, Mar 26, 2014 at 3:22 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: [...] Still not able to boot with this patch applied: Perhaps a change as below helps ? From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Fabio Estevam
On Wed, Mar 26, 2014 at 4:57 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Perhaps a change as below helps ? From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 From: Sylwester Nawrocki s.nawro...@samsung.com Date: Wed, 26 Mar 2014 20:54:13 +0100 Subject:

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Gregory CLEMENT
On 26/03/2014 21:14, Fabio Estevam wrote: On Wed, Mar 26, 2014 at 4:57 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Perhaps a change as below helps ? From 85ee85e4a92b42442354f3f2454be50c173e1c59 Mon Sep 17 00:00:00 2001 From: Sylwester Nawrocki s.nawro...@samsung.com Date:

Re: [PATCH] clk: register fixed-clock only if #clock-cells property is present

2014-03-26 Thread Fabio Estevam
On Wed, Mar 26, 2014 at 5:25 PM, Gregory CLEMENT gregory.clem...@free-electrons.com wrote: However, Fabio, could you apply the following patch without the patch clk: reverse default clk provider initialization order in of_clk_init() and then sent me the traces. I would like to be sure that