Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-14 Thread Heiko Stübner
Am Montag, 13. Juni 2016, 20:49:39 schrieb Doug Anderson: > Hi, > > On Mon, Jun 13, 2016 at 8:02 PM, Xing Zheng wrote: > > Hi Doug, > > > > On 2016年06月14日 07:46, Doug Anderson wrote: > >> Even if it's not much power, it seems like we should still turn it off > >> and

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-14 Thread Heiko Stübner
Am Montag, 13. Juni 2016, 20:49:39 schrieb Doug Anderson: > Hi, > > On Mon, Jun 13, 2016 at 8:02 PM, Xing Zheng wrote: > > Hi Doug, > > > > On 2016年06月14日 07:46, Doug Anderson wrote: > >> Even if it's not much power, it seems like we should still turn it off > >> and on in the right place.

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-13 Thread Doug Anderson
Hi, On Mon, Jun 13, 2016 at 8:02 PM, Xing Zheng wrote: > Hi Doug, > > On 2016年06月14日 07:46, Doug Anderson wrote: >> >> >> Even if it's not much power, it seems like we should still turn it off >> and on in the right place. Unless I'm mistaken it should be such a >>

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-13 Thread Doug Anderson
Hi, On Mon, Jun 13, 2016 at 8:02 PM, Xing Zheng wrote: > Hi Doug, > > On 2016年06月14日 07:46, Doug Anderson wrote: >> >> >> Even if it's not much power, it seems like we should still turn it off >> and on in the right place. Unless I'm mistaken it should be such a >> simple patch provide the

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-13 Thread Xing Zheng
Hi Doug, On 2016年06月14日 07:46, Doug Anderson wrote: Even if it's not much power, it seems like we should still turn it off and on in the right place. Unless I'm mistaken it should be such a simple patch provide the clock to the right driver and then get the clock when appropriate. Yes, I

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-13 Thread Xing Zheng
Hi Doug, On 2016年06月14日 07:46, Doug Anderson wrote: Even if it's not much power, it seems like we should still turn it off and on in the right place. Unless I'm mistaken it should be such a simple patch provide the clock to the right driver and then get the clock when appropriate. Yes, I

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-13 Thread Doug Anderson
Xing, On Sun, Jun 12, 2016 at 8:10 PM, Xing Zheng wrote: > Hi Doug, > > > On 2016年06月13日 05:32, Doug Anderson wrote: >> >> Xing, >> >> On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng >> wrote: >>> >>> The pclk_vio_grf supply power for GRF IOs, if

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-13 Thread Doug Anderson
Xing, On Sun, Jun 12, 2016 at 8:10 PM, Xing Zheng wrote: > Hi Doug, > > > On 2016年06月13日 05:32, Doug Anderson wrote: >> >> Xing, >> >> On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng >> wrote: >>> >>> The pclk_vio_grf supply power for GRF IOs, if it is disabled, will >>> cause abnormal operation of

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Xing Zheng
Hi Doug, On 2016年06月13日 11:10, Xing Zheng wrote: Hi Doug, On 2016年06月13日 05:32, Doug Anderson wrote: Xing, On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng wrote: The pclk_vio_grf supply power for GRF IOs, if it is disabled, will cause abnormal operation of the GRF.

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Xing Zheng
Hi Doug, On 2016年06月13日 11:10, Xing Zheng wrote: Hi Doug, On 2016年06月13日 05:32, Doug Anderson wrote: Xing, On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng wrote: The pclk_vio_grf supply power for GRF IOs, if it is disabled, will cause abnormal operation of the GRF. The clock tree of the

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Xing Zheng
Hi Doug, On 2016年06月13日 05:32, Doug Anderson wrote: Xing, On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng wrote: The pclk_vio_grf supply power for GRF IOs, if it is disabled, will cause abnormal operation of the GRF. The clock tree of the pclk_vio like this:

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Xing Zheng
Hi Doug, On 2016年06月13日 05:32, Doug Anderson wrote: Xing, On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng wrote: The pclk_vio_grf supply power for GRF IOs, if it is disabled, will cause abnormal operation of the GRF. The clock tree of the pclk_vio like this: | --> pclk_vio_grf ...

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Doug Anderson
Xing, On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng wrote: > The pclk_vio_grf supply power for GRF IOs, if it is disabled, will > cause abnormal operation of the GRF. > > The clock tree of the pclk_vio like this: > | --> pclk_vio_grf > ... pclk_vio | -->

Re: [PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Doug Anderson
Xing, On Sun, Jun 12, 2016 at 2:48 AM, Xing Zheng wrote: > The pclk_vio_grf supply power for GRF IOs, if it is disabled, will > cause abnormal operation of the GRF. > > The clock tree of the pclk_vio like this: > | --> pclk_vio_grf > ... pclk_vio | --> pclk_mipi_dsi1 >

[PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Xing Zheng
The pclk_vio_grf supply power for GRF IOs, if it is disabled, will cause abnormal operation of the GRF. The clock tree of the pclk_vio like this: | --> pclk_vio_grf ... pclk_vio | --> pclk_mipi_dsi1 | --> pclk_mipi_dsi0 and the pclk_mipi_dsi0 and pclk_mipi_dsi1 don't

[PATCH] clk: rockchip: add pclk_vio_grf to critical clock on the RK3399

2016-06-12 Thread Xing Zheng
The pclk_vio_grf supply power for GRF IOs, if it is disabled, will cause abnormal operation of the GRF. The clock tree of the pclk_vio like this: | --> pclk_vio_grf ... pclk_vio | --> pclk_mipi_dsi1 | --> pclk_mipi_dsi0 and the pclk_mipi_dsi0 and pclk_mipi_dsi1 don't