Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-06 Thread Sergei Shtylyov
Hello. On 2/5/2015 8:19 PM, Laurent Pinchart wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven Acked-by: Wolfram Sang I agree that this should not be fixed in the core because the fixup is really

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-06 Thread Sergei Shtylyov
Hello. On 2/5/2015 8:19 PM, Laurent Pinchart wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-05 Thread Mike Turquette
Quoting Laurent Pinchart (2015-02-05 09:19:14) > Hi Sergei, > > On Thursday 05 February 2015 01:14:46 Sergei Shtylyov wrote: > > On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: > > > Anyone may call clk_round_rate() with a zero rate value, so we have to > > > protect against that. > >

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-05 Thread Laurent Pinchart
Hi Sergei, On Thursday 05 February 2015 01:14:46 Sergei Shtylyov wrote: > On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: > > Anyone may call clk_round_rate() with a zero rate value, so we have to > > protect against that. > > > > Signed-off-by: Geert Uytterhoeven > >

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-05 Thread Laurent Pinchart
Hi Sergei, On Thursday 05 February 2015 01:14:46 Sergei Shtylyov wrote: On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by:

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-05 Thread Mike Turquette
Quoting Laurent Pinchart (2015-02-05 09:19:14) Hi Sergei, On Thursday 05 February 2015 01:14:46 Sergei Shtylyov wrote: On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven Acked-by: Wolfram Sang I agree that this should not be fixed in the core because the fixup is really

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Mike Turquette
Quoting Wolfram Sang (2015-02-04 09:32:34) > On Wed, Feb 04, 2015 at 01:27:21PM +0100, Geert Uytterhoeven wrote: > > Anyone may call clk_round_rate() with a zero rate value, so we have to > > protect against that. > > > > Signed-off-by: Geert Uytterhoeven > > Acked-by: Wolfram Sang > > I

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/05/2015 01:01 AM, Mike Turquette wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven Acked-by: Wolfram Sang I agree that this should not be fixed in the core because the fixup is really

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Mike Turquette
Quoting Sergei Shtylyov (2015-02-04 09:45:14) > Hello. > > On 02/04/2015 08:32 PM, Wolfram Sang wrote: > > >> Anyone may call clk_round_rate() with a zero rate value, so we have to > >> protect against that. > > >> Signed-off-by: Geert Uytterhoeven > > > Acked-by: Wolfram Sang > > > I agree

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 08:32 PM, Wolfram Sang wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven Acked-by: Wolfram Sang I agree that this should not be fixed in the core because the fixup is really

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Wolfram Sang
On Wed, Feb 04, 2015 at 01:27:21PM +0100, Geert Uytterhoeven wrote: > Anyone may call clk_round_rate() with a zero rate value, so we have to > protect against that. > > Signed-off-by: Geert Uytterhoeven Acked-by: Wolfram Sang I agree that this should not be fixed in the core because the fixup

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Laurent Pinchart
Hi Sergei, On Wednesday 04 February 2015 16:31:29 Sergei Shtylyov wrote: > On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote: > > Anyone may call clk_round_rate() with a zero rate value, so we have to > > protect against that. > > Shouldn't this be checked and fixed up in clk_round_rate() then?

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Shouldn't this be checked and fixed up in clk_round_rate() then? Signed-off-by: Geert Uytterhoeven WBR, Sergei -- To unsubscribe from

[PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Geert Uytterhoeven
Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven --- This was triggered by the bad version of "clk: Add rate constraints to clocks", but can happen regardless, cfr. https://lkml.org/lkml/2015/1/29/560

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Wolfram Sang
On Wed, Feb 04, 2015 at 01:27:21PM +0100, Geert Uytterhoeven wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 08:32 PM, Wolfram Sang wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Mike Turquette
Quoting Sergei Shtylyov (2015-02-04 09:45:14) Hello. On 02/04/2015 08:32 PM, Wolfram Sang wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Mike Turquette
Quoting Wolfram Sang (2015-02-04 09:32:34) On Wed, Feb 04, 2015 at 01:27:21PM +0100, Geert Uytterhoeven wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/05/2015 01:01 AM, Mike Turquette wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Laurent Pinchart
Hi Sergei, On Wednesday 04 February 2015 16:31:29 Sergei Shtylyov wrote: On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Shouldn't this be checked and fixed up in clk_round_rate() then? Not all

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Shouldn't this be checked and fixed up in clk_round_rate() then? Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be WBR, Sergei

[PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Geert Uytterhoeven
Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be --- This was triggered by the bad version of clk: Add rate constraints to clocks, but can happen regardless, cfr.