Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-06-01 Thread Marek Vasut
On 06/01/2018 03:46 AM, Steve Longerbeam wrote: > > > On 05/31/2018 12:37 PM, Marek Vasut wrote: >> On 05/31/2018 08:52 PM, Steve Longerbeam wrote: >>> >>> On 05/31/2018 11:35 AM, Marek Vasut wrote: On 05/31/2018 08:32 PM, Steve Longerbeam wrote: > Hi Marek, > > > On 05/31/20

Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Steve Longerbeam
On 05/31/2018 12:37 PM, Marek Vasut wrote: On 05/31/2018 08:52 PM, Steve Longerbeam wrote: On 05/31/2018 11:35 AM, Marek Vasut wrote: On 05/31/2018 08:32 PM, Steve Longerbeam wrote: Hi Marek, On 05/31/2018 11:25 AM, Marek Vasut wrote: On 05/31/2018 08:23 PM, Steve Longerbeam wrote: Jus

Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Marek Vasut
On 05/31/2018 08:52 PM, Steve Longerbeam wrote: > > > On 05/31/2018 11:35 AM, Marek Vasut wrote: >> On 05/31/2018 08:32 PM, Steve Longerbeam wrote: >>> Hi Marek, >>> >>> >>> On 05/31/2018 11:25 AM, Marek Vasut wrote: On 05/31/2018 08:23 PM, Steve Longerbeam wrote: > Just return zero for

Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Steve Longerbeam
On 05/31/2018 11:35 AM, Marek Vasut wrote: On 05/31/2018 08:32 PM, Steve Longerbeam wrote: Hi Marek, On 05/31/2018 11:25 AM, Marek Vasut wrote: On 05/31/2018 08:23 PM, Steve Longerbeam wrote: Just return zero for a rounded rate if requested rate is zero. This was caught by CONFIG_UBSAN:

Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Marek Vasut
On 05/31/2018 08:32 PM, Steve Longerbeam wrote: > Hi Marek, > > > On 05/31/2018 11:25 AM, Marek Vasut wrote: >> On 05/31/2018 08:23 PM, Steve Longerbeam wrote: >>> Just return zero for a rounded rate if requested rate is zero. >>> >>> This was caught by CONFIG_UBSAN: >>> >>> [  192.266748] UBSAN:

Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Steve Longerbeam
Hi Marek, On 05/31/2018 11:25 AM, Marek Vasut wrote: On 05/31/2018 08:23 PM, Steve Longerbeam wrote: Just return zero for a rounded rate if requested rate is zero. This was caught by CONFIG_UBSAN: [ 192.266748] UBSAN: Undefined behaviour in drivers/clk/clk-versaclock5.c:513:17 [ 192.27405

Re: [PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Marek Vasut
On 05/31/2018 08:23 PM, Steve Longerbeam wrote: > Just return zero for a rounded rate if requested rate is zero. > > This was caught by CONFIG_UBSAN: > > [ 192.266748] UBSAN: Undefined behaviour in > drivers/clk/clk-versaclock5.c:513:17 > [ 192.274050] division by zero > [ 192.276976] CPU: 0

[PATCH] clk: vc5: Fix div-by-0 when rounding a rate of zero

2018-05-31 Thread Steve Longerbeam
Just return zero for a rounded rate if requested rate is zero. This was caught by CONFIG_UBSAN: [ 192.266748] UBSAN: Undefined behaviour in drivers/clk/clk-versaclock5.c:513:17 [ 192.274050] division by zero [ 192.276976] CPU: 0 PID: 2579 Comm: vsp-unit-test-0 Tainted: GB WC 4.14.