Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-25 Thread Catalin Marinas
On Tue, Feb 24, 2015 at 04:54:17PM -0500, Chris Metcalf wrote: > On 2/14/2015 6:22 AM, Catalin Marinas wrote: > >1. user populates sival_int compat_sigevent and invokes > >compat_sys_mq_notify() > >2. kernel get_compat_sigevent() copies compat_sigevent into the native > >sigevent. compat

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-25 Thread Catalin Marinas
On Tue, Feb 24, 2015 at 04:54:17PM -0500, Chris Metcalf wrote: On 2/14/2015 6:22 AM, Catalin Marinas wrote: 1. user populates sival_int compat_sigevent and invokes compat_sys_mq_notify() 2. kernel get_compat_sigevent() copies compat_sigevent into the native sigevent. compat and native

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-24 Thread Chris Metcalf
On 2/14/2015 6:22 AM, Catalin Marinas wrote: 1. user populates sival_int compat_sigevent and invokes compat_sys_mq_notify() 2. kernel get_compat_sigevent() copies compat_sigevent into the native sigevent. compat and native sival_int are the same, no problem so far. The other half of

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-24 Thread Chris Metcalf
On 2/14/2015 6:22 AM, Catalin Marinas wrote: 1. user populates sival_int compat_sigevent and invokes compat_sys_mq_notify() 2. kernel get_compat_sigevent() copies compat_sigevent into the native sigevent. compat and native sival_int are the same, no problem so far. The other half of

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-20 Thread Chris Metcalf
On 2/14/2015 6:22 AM, Catalin Marinas wrote: 1. user populates sival_int compat_sigevent and invokes compat_sys_mq_notify() 2. kernel get_compat_sigevent() copies compat_sigevent into the native sigevent. compat and native sival_int are the same, no problem so far. The other half of

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-20 Thread Chris Metcalf
On 2/14/2015 6:22 AM, Catalin Marinas wrote: 1. user populates sival_int compat_sigevent and invokes compat_sys_mq_notify() 2. kernel get_compat_sigevent() copies compat_sigevent into the native sigevent. compat and native sival_int are the same, no problem so far. The other half of

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-16 Thread Bamvor Jian Zhang
On 2015/2/13 18:44, Catalin Marinas wrote: > On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: >> On 2015/2/11 23:40, Catalin Marinas wrote: >>> On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: > On Tue, Feb 10,

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-16 Thread Bamvor Jian Zhang
On 2015/2/14 19:22, Catalin Marinas wrote: > On Fri, Feb 13, 2015 at 04:56:29PM -0500, Chris Metcalf wrote: >> On 2/13/2015 5:44 AM, Catalin Marinas wrote: >>> On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: diff --git a/arch/arm64/kernel/signal32.c

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-16 Thread Bamvor Jian Zhang
On 2015/2/14 19:22, Catalin Marinas wrote: On Fri, Feb 13, 2015 at 04:56:29PM -0500, Chris Metcalf wrote: On 2/13/2015 5:44 AM, Catalin Marinas wrote: On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: diff --git a/arch/arm64/kernel/signal32.c b/arch/arm64/kernel/signal32.c

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-16 Thread Bamvor Jian Zhang
On 2015/2/13 18:44, Catalin Marinas wrote: On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: On 2015/2/11 23:40, Catalin Marinas wrote: On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: On Tue, Feb 10, 2015 at

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-14 Thread Catalin Marinas
On Fri, Feb 13, 2015 at 04:56:29PM -0500, Chris Metcalf wrote: > On 2/13/2015 5:44 AM, Catalin Marinas wrote: > >On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: > >>diff --git a/arch/arm64/kernel/signal32.c b/arch/arm64/kernel/signal32.c > >>index e299de396e9b..32601939a3c8

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-14 Thread Catalin Marinas
On Fri, Feb 13, 2015 at 04:56:29PM -0500, Chris Metcalf wrote: On 2/13/2015 5:44 AM, Catalin Marinas wrote: On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: diff --git a/arch/arm64/kernel/signal32.c b/arch/arm64/kernel/signal32.c index e299de396e9b..32601939a3c8 100644 ---

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-13 Thread Chris Metcalf
On 2/13/2015 5:44 AM, Catalin Marinas wrote: On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: On 2015/2/11 23:40, Catalin Marinas wrote: On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: On Tue, Feb 10, 2015 at

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-13 Thread Catalin Marinas
On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: > On 2015/2/11 23:40, Catalin Marinas wrote: > > On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: > >> On 2015/2/10 20:27, Catalin Marinas wrote: > >>> On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor)

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-13 Thread Bamvor Jian Zhang
On 2015/2/11 23:40, Catalin Marinas wrote: > On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: >> On 2015/2/10 20:27, Catalin Marinas wrote: >>> On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: ... > The native sigval_t is also a union but on 64-bit big endian,

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-13 Thread Catalin Marinas
On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: On 2015/2/11 23:40, Catalin Marinas wrote: On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote:

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-13 Thread Bamvor Jian Zhang
On 2015/2/11 23:40, Catalin Marinas wrote: On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: ... The native sigval_t is also a union but on 64-bit big endian, the

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-13 Thread Chris Metcalf
On 2/13/2015 5:44 AM, Catalin Marinas wrote: On Fri, Feb 13, 2015 at 04:00:43PM +0800, Bamvor Jian Zhang wrote: On 2015/2/11 23:40, Catalin Marinas wrote: On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: On Tue, Feb 10, 2015 at

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-11 Thread Catalin Marinas
On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: > On 2015/2/10 20:27, Catalin Marinas wrote: > > On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: > >> In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in > >> big endian kernel compare with low

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-11 Thread Bamvor Jian Zhang
On 2015/2/10 20:27, Catalin Marinas wrote: > cc'ing linux-arch as well. > > On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: >> In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in >> big endian kernel compare with low 32bit of sigval_ptr in little >> endian

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-11 Thread Catalin Marinas
On Wed, Feb 11, 2015 at 07:22:08PM +0800, Bamvor Jian Zhang wrote: On 2015/2/10 20:27, Catalin Marinas wrote: On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in big endian kernel compare with low 32bit of

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-11 Thread Bamvor Jian Zhang
On 2015/2/10 20:27, Catalin Marinas wrote: cc'ing linux-arch as well. On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in big endian kernel compare with low 32bit of sigval_ptr in little endian kernel.

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-10 Thread Catalin Marinas
cc'ing linux-arch as well. On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: > In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in > big endian kernel compare with low 32bit of sigval_ptr in little > endian kernel. reference: > > typedef union sigval { >

[PATCH] compat: Fix endian issue in union sigval

2015-02-10 Thread Zhang Jian(Bamvor)
In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in big endian kernel compare with low 32bit of sigval_ptr in little endian kernel. reference: typedef union sigval { int sival_int; void *sival_ptr; } sigval_t; During compat_mq_notify or

[PATCH] compat: Fix endian issue in union sigval

2015-02-10 Thread Zhang Jian(Bamvor)
In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in big endian kernel compare with low 32bit of sigval_ptr in little endian kernel. reference: typedef union sigval { int sival_int; void *sival_ptr; } sigval_t; During compat_mq_notify or

Re: [PATCH] compat: Fix endian issue in union sigval

2015-02-10 Thread Catalin Marinas
cc'ing linux-arch as well. On Tue, Feb 10, 2015 at 10:10:11AM +, Zhang Jian(Bamvor) wrote: In 64bit architecture, sigval_int is the high 32bit of sigval_ptr in big endian kernel compare with low 32bit of sigval_ptr in little endian kernel. reference: typedef union sigval {