Re: [PATCH] cpufreq: s5pv210: add missing of_node_put

2017-07-17 Thread Viresh Kumar
On 15-07-17, 21:40, Julia Lawall wrote: > for_each_compatible_node performs an of_node_get on each iteration, so a > return from the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > local idexpression n; >

Re: [PATCH] cpufreq: s5pv210: add missing of_node_put

2017-07-17 Thread Viresh Kumar
On 15-07-17, 21:40, Julia Lawall wrote: > for_each_compatible_node performs an of_node_get on each iteration, so a > return from the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > local idexpression n; >

[PATCH] cpufreq: s5pv210: add missing of_node_put

2017-07-15 Thread Julia Lawall
for_each_compatible_node performs an of_node_get on each iteration, so a return from the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression n; expression e,e1,e2; statement S; iterator i1; iterator name

[PATCH] cpufreq: s5pv210: add missing of_node_put

2017-07-15 Thread Julia Lawall
for_each_compatible_node performs an of_node_get on each iteration, so a return from the loop requires an of_node_put. The semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression n; expression e,e1,e2; statement S; iterator i1; iterator name