Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-24 Thread Yue Hu
On Wed, 24 Feb 2021 13:46:11 +0100 "Rafael J. Wysocki" wrote: > On Wed, Feb 24, 2021 at 3:24 AM Yue Hu wrote: > > > > On Mon, 22 Feb 2021 15:30:34 +0100 > > "Rafael J. Wysocki" wrote: > > > > > On Mon, Feb 22, 2021 at 2:57 PM Yue Hu wrote: > > > > > > > > On Mon, 22 Feb 2021 11:00:14

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-24 Thread Rafael J. Wysocki
On Wed, Feb 24, 2021 at 3:24 AM Yue Hu wrote: > > On Mon, 22 Feb 2021 15:30:34 +0100 > "Rafael J. Wysocki" wrote: > > > On Mon, Feb 22, 2021 at 2:57 PM Yue Hu wrote: > > > > > > On Mon, 22 Feb 2021 11:00:14 +0530 > > > Viresh Kumar wrote: > > > > > > > On 19-02-21, 19:45, Yue Hu wrote: > > > >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-23 Thread Yue Hu
On Mon, 22 Feb 2021 15:30:34 +0100 "Rafael J. Wysocki" wrote: > On Mon, Feb 22, 2021 at 2:57 PM Yue Hu wrote: > > > > On Mon, 22 Feb 2021 11:00:14 +0530 > > Viresh Kumar wrote: > > > > > On 19-02-21, 19:45, Yue Hu wrote: > > > > We will set next_f to next_freq(previous freq) if next_f is >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-22 Thread Rafael J. Wysocki
On Mon, Feb 22, 2021 at 2:57 PM Yue Hu wrote: > > On Mon, 22 Feb 2021 11:00:14 +0530 > Viresh Kumar wrote: > > > On 19-02-21, 19:45, Yue Hu wrote: > > > We will set next_f to next_freq(previous freq) if next_f is > > > reduced for busy CPU. Then the next sugov_update_next_freq() will check > > >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-22 Thread Yue Hu
On Mon, 22 Feb 2021 11:00:14 +0530 Viresh Kumar wrote: > On 19-02-21, 19:45, Yue Hu wrote: > > We will set next_f to next_freq(previous freq) if next_f is > > reduced for busy CPU. Then the next sugov_update_next_freq() will check > > if next_freq matches next_f if need_freq_update is not set. >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-21 Thread Viresh Kumar
On 19-02-21, 19:45, Yue Hu wrote: > We will set next_f to next_freq(previous freq) if next_f is > reduced for busy CPU. Then the next sugov_update_next_freq() will check > if next_freq matches next_f if need_freq_update is not set. > Obviously, we will do nothing for the case. And The related

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-19 Thread Yue Hu
On Fri, 19 Feb 2021 15:05:51 +0530 Viresh Kumar wrote: > On 19-02-21, 16:20, Yue Hu wrote: > > However, we will skip the update if need_freq_update is not set. > > Not really, we will update freq periodically nevertheless, around > every 10ms or something.. > > > And do the update if

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-19 Thread Viresh Kumar
On 19-02-21, 16:20, Yue Hu wrote: > However, we will skip the update if need_freq_update is not set. Not really, we will update freq periodically nevertheless, around every 10ms or something.. > And do the update if need_freq_update is set. Yeah, that breaks the periodic cycle to attend to some

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-19 Thread Yue Hu
On Fri, 19 Feb 2021 13:12:49 +0530 Viresh Kumar wrote: > On 19-02-21, 14:41, Yue Hu wrote: > > On Fri, 19 Feb 2021 09:39:33 +0530 > > Viresh Kumar wrote: > > > > > On 19-02-21, 11:38, Yue Hu wrote: > > > > There's a possibility: we will use the previous freq to update > > > > if next_f is

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 19-02-21, 14:41, Yue Hu wrote: > On Fri, 19 Feb 2021 09:39:33 +0530 > Viresh Kumar wrote: > > > On 19-02-21, 11:38, Yue Hu wrote: > > > There's a possibility: we will use the previous freq to update if > > > next_f is reduced for busy CPU if need_freq_update is set in > > >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Yue Hu
On Fri, 19 Feb 2021 09:39:33 +0530 Viresh Kumar wrote: > On 19-02-21, 11:38, Yue Hu wrote: > > There's a possibility: we will use the previous freq to update if > > next_f is reduced for busy CPU if need_freq_update is set in > > sugov_update_next_freq(). > > Right. > > > This possibility

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 19-02-21, 11:38, Yue Hu wrote: > There's a possibility: we will use the previous freq to update if next_f > is reduced for busy CPU if need_freq_update is set in > sugov_update_next_freq(). Right. > This possibility would happen now? And this > update is what we want if it happens? This is

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Yue Hu
On Thu, 18 Feb 2021 15:50:29 +0530 Viresh Kumar wrote: > On 18-02-21, 16:25, Yue Hu wrote: > > From: Yue Hu > > > > For busy CPU case, we do not need to avoid freq reduction if limits > > change since commit 600f5badb78c ("cpufreq: schedutil: Don't skip > > freq update when limits change"). >

Re: [PATCH] cpufreq: schedutil: Don't consider freq reduction to busy CPU if need_freq_update is set

2021-02-18 Thread Viresh Kumar
On 18-02-21, 16:25, Yue Hu wrote: > From: Yue Hu > > For busy CPU case, we do not need to avoid freq reduction if limits > change since commit 600f5badb78c ("cpufreq: schedutil: Don't skip > freq update when limits change"). > > Later, commit 23a881852f3e ("cpufreq: schedutil: Don't skip freq >