Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-22 Thread Herbert Xu
On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > When using the "aes-asm" implementation of AES (*not* the AES-NI > implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled, the > following warning was reported, along with a

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-22 Thread Herbert Xu
On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > When using the "aes-asm" implementation of AES (*not* the AES-NI > implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled, the > following warning was reported, along with a long unwinder dump: >

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-18 Thread Eric Biggers
On Thu, May 18, 2017 at 08:56:32PM -0500, Josh Poimboeuf wrote: > > > > Hmm, it looks like a number of other algorithms in arch/x86/crypto/ use > > %rbp (or > > %ebp), e.g. blowfish, camellia, cast5, and aes-i586. Presumably they have > > the > > same problem. I'm a little confused: do these

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-18 Thread Eric Biggers
On Thu, May 18, 2017 at 08:56:32PM -0500, Josh Poimboeuf wrote: > > > > Hmm, it looks like a number of other algorithms in arch/x86/crypto/ use > > %rbp (or > > %ebp), e.g. blowfish, camellia, cast5, and aes-i586. Presumably they have > > the > > same problem. I'm a little confused: do these

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-18 Thread Josh Poimboeuf
On Wed, May 17, 2017 at 03:21:41PM -0700, Eric Biggers wrote: > On Wed, May 17, 2017 at 03:44:27PM -0500, Josh Poimboeuf wrote: > > On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > When using the "aes-asm" implementation of

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-18 Thread Josh Poimboeuf
On Wed, May 17, 2017 at 03:21:41PM -0700, Eric Biggers wrote: > On Wed, May 17, 2017 at 03:44:27PM -0500, Josh Poimboeuf wrote: > > On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > When using the "aes-asm" implementation of AES (*not* the AES-NI

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-17 Thread Eric Biggers
On Wed, May 17, 2017 at 03:44:27PM -0500, Josh Poimboeuf wrote: > On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > When using the "aes-asm" implementation of AES (*not* the AES-NI > > implementation) on an x86_64, v4.12-rc1 kernel

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-17 Thread Eric Biggers
On Wed, May 17, 2017 at 03:44:27PM -0500, Josh Poimboeuf wrote: > On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > When using the "aes-asm" implementation of AES (*not* the AES-NI > > implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled,

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-17 Thread Josh Poimboeuf
On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > When using the "aes-asm" implementation of AES (*not* the AES-NI > implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled, the > following warning was reported, along with a

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-17 Thread Josh Poimboeuf
On Tue, May 16, 2017 at 09:03:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > When using the "aes-asm" implementation of AES (*not* the AES-NI > implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled, the > following warning was reported, along with a long unwinder dump: >

[PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-16 Thread Eric Biggers
From: Eric Biggers When using the "aes-asm" implementation of AES (*not* the AES-NI implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled, the following warning was reported, along with a long unwinder dump: WARNING: kernel stack regs at

[PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-16 Thread Eric Biggers
From: Eric Biggers When using the "aes-asm" implementation of AES (*not* the AES-NI implementation) on an x86_64, v4.12-rc1 kernel with lockdep enabled, the following warning was reported, along with a long unwinder dump: WARNING: kernel stack regs at c9643558 in