Re: [PATCH] dcache: error out on failures to store terminating NUL

2014-01-24 Thread Al Viro
On Fri, Jan 24, 2014 at 01:17:46PM +0100, Denys Vlasenko wrote: > A number of routines wasn't checking that the initial call > to prepend "\0" to result buffer doesn't fail. > > Coredump code was seeing d_path() with zero-sized buffer > to erroneously return bogus data (non-error pointer >

[PATCH] dcache: error out on failures to store terminating NUL

2014-01-24 Thread Denys Vlasenko
A number of routines wasn't checking that the initial call to prepend "\0" to result buffer doesn't fail. Coredump code was seeing d_path() with zero-sized buffer to erroneously return bogus data (non-error pointer pointing before buffer start). Users report that this change fixes it. Cc: Jan

[PATCH] dcache: error out on failures to store terminating NUL

2014-01-24 Thread Denys Vlasenko
A number of routines wasn't checking that the initial call to prepend \0 to result buffer doesn't fail. Coredump code was seeing d_path() with zero-sized buffer to erroneously return bogus data (non-error pointer pointing before buffer start). Users report that this change fixes it. Cc: Jan

Re: [PATCH] dcache: error out on failures to store terminating NUL

2014-01-24 Thread Al Viro
On Fri, Jan 24, 2014 at 01:17:46PM +0100, Denys Vlasenko wrote: A number of routines wasn't checking that the initial call to prepend \0 to result buffer doesn't fail. Coredump code was seeing d_path() with zero-sized buffer to erroneously return bogus data (non-error pointer pointing