RE: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-28 Thread Luck, Tony
> I agree with this. Most of it looks easily fixable, but how would I > enable the fix for ia64? For PA it's simple: I'll just use > CONFIG_STACK_GROWSUP, but that won't work for you. ia64 has an ugly chicken vs. egg build dependency. When trying to build our asm-offsets.h file (to get #define

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-28 Thread James Bottomley
On Wed, 2012-07-18 at 10:35 -0700, Tony Luck wrote: > The stack_not_used() function in assumes that stacks > grow downwards. This is not true on IA64 or PARISC, so this function > would walk off in the wrong direction and into the weeds. OK, so looking at all of this, that statement's not quite

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-28 Thread James Bottomley
On Wed, 2012-07-18 at 10:35 -0700, Tony Luck wrote: The stack_not_used() function in linux/sched.h assumes that stacks grow downwards. This is not true on IA64 or PARISC, so this function would walk off in the wrong direction and into the weeds. OK, so looking at all of this, that statement's

RE: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-28 Thread Luck, Tony
I agree with this. Most of it looks easily fixable, but how would I enable the fix for ia64? For PA it's simple: I'll just use CONFIG_STACK_GROWSUP, but that won't work for you. ia64 has an ugly chicken vs. egg build dependency. When trying to build our asm-offsets.h file (to get #define

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-26 Thread Peter Chubb
> "Ingo" == Ingo Molnar writes: Ingo> * James Bottomley wrote: >> Since the problem is an invalid assumption about how the stack >> grows, why not just condition it on that. We actually have a >> config option for this: CONFIG_STACK_GROWSUP. But for some reason >> ia64 doesn't define

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-26 Thread Ingo Molnar
* James Bottomley wrote: > On Wed, 2012-07-25 at 09:45 +0200, Ingo Molnar wrote: > > * Tony Luck wrote: > > > > > The stack_not_used() function in assumes that stacks > > > grow downwards. This is not true on IA64 or PARISC, so this function > > > would walk off in the wrong direction and

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-26 Thread Ingo Molnar
* James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2012-07-25 at 09:45 +0200, Ingo Molnar wrote: * Tony Luck tony.l...@intel.com wrote: The stack_not_used() function in linux/sched.h assumes that stacks grow downwards. This is not true on IA64 or PARISC, so this

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-26 Thread Peter Chubb
Ingo == Ingo Molnar mi...@kernel.org writes: Ingo * James Bottomley james.bottom...@hansenpartnership.com wrote: Since the problem is an invalid assumption about how the stack grows, why not just condition it on that. We actually have a config option for this: CONFIG_STACK_GROWSUP. But for

RE: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread Luck, Tony
> Since the problem is an invalid assumption about how the stack grows, > why not just condition it on that. We actually have a config option for > this: CONFIG_STACK_GROWSUP. But for some reason ia64 doesn't define > this, why not, Tony? It looks deliberate because you have replaced a > lot of

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread James Bottomley
On Wed, 2012-07-25 at 09:45 +0200, Ingo Molnar wrote: > * Tony Luck wrote: > > > The stack_not_used() function in assumes that stacks > > grow downwards. This is not true on IA64 or PARISC, so this function > > would walk off in the wrong direction and into the weeds. > > > > Found on IA64

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread Ingo Molnar
* Tony Luck wrote: > The stack_not_used() function in assumes that stacks > grow downwards. This is not true on IA64 or PARISC, so this function > would walk off in the wrong direction and into the weeds. > > Found on IA64 because of a compilation failure with recursive dependencies > on

RE: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread Luck, Tony
Since the problem is an invalid assumption about how the stack grows, why not just condition it on that. We actually have a config option for this: CONFIG_STACK_GROWSUP. But for some reason ia64 doesn't define this, why not, Tony? It looks deliberate because you have replaced a lot of

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread Ingo Molnar
* Tony Luck tony.l...@intel.com wrote: The stack_not_used() function in linux/sched.h assumes that stacks grow downwards. This is not true on IA64 or PARISC, so this function would walk off in the wrong direction and into the weeds. Found on IA64 because of a compilation failure with

Re: [PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-25 Thread James Bottomley
On Wed, 2012-07-25 at 09:45 +0200, Ingo Molnar wrote: * Tony Luck tony.l...@intel.com wrote: The stack_not_used() function in linux/sched.h assumes that stacks grow downwards. This is not true on IA64 or PARISC, so this function would walk off in the wrong direction and into the weeds.

[PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-18 Thread Tony Luck
The stack_not_used() function in assumes that stacks grow downwards. This is not true on IA64 or PARISC, so this function would walk off in the wrong direction and into the weeds. Found on IA64 because of a compilation failure with recursive dependencies on IA64_TASKSIZE and

[PATCH] debug: Do not permit CONFIG_DEBUG_STACK_USAGE=y on IA64 or PARISC

2012-07-18 Thread Tony Luck
The stack_not_used() function in linux/sched.h assumes that stacks grow downwards. This is not true on IA64 or PARISC, so this function would walk off in the wrong direction and into the weeds. Found on IA64 because of a compilation failure with recursive dependencies on IA64_TASKSIZE and