Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-13 Thread hpa
On July 13, 2020 12:27:02 PM PDT, Tom Rix wrote: > >On 7/12/20 3:21 PM, h...@zytor.com wrote: >> On July 12, 2020 8:12:43 AM PDT, Tom Rix wrote: >>> On 7/12/20 6:09 AM, H. Peter Anvin wrote: On 2020-07-12 05:59, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis

Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-13 Thread Tom Rix
On 7/12/20 3:21 PM, h...@zytor.com wrote: > On July 12, 2020 8:12:43 AM PDT, Tom Rix wrote: >> On 7/12/20 6:09 AM, H. Peter Anvin wrote: >>> On 2020-07-12 05:59, t...@redhat.com wrote: From: Tom Rix clang static analysis flags this error

Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-12 Thread hpa
On July 12, 2020 8:12:43 AM PDT, Tom Rix wrote: > >On 7/12/20 6:09 AM, H. Peter Anvin wrote: >> On 2020-07-12 05:59, t...@redhat.com wrote: >>> From: Tom Rix >>> >>> clang static analysis flags this error >>> >>> lib/decompress_bunzip2.c:671:13: warning: Result of 'malloc' is >converted >>> to

Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-12 Thread Joe Perches
On Sun, 2020-07-12 at 08:12 -0700, Tom Rix wrote: > On 7/12/20 6:09 AM, H. Peter Anvin wrote: > > On 2020-07-12 05:59, t...@redhat.com wrote: > > > From: Tom Rix [] > > > So change the type in sizeof to 'unsigned int' > > You must be kidding. > > > > If you want to change it, change it to

Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-12 Thread Tom Rix
On 7/12/20 6:09 AM, H. Peter Anvin wrote: > On 2020-07-12 05:59, t...@redhat.com wrote: >> From: Tom Rix >> >> clang static analysis flags this error >> >> lib/decompress_bunzip2.c:671:13: warning: Result of 'malloc' is converted >> to a pointer of type 'unsigned int', which is incompatible

Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-12 Thread H. Peter Anvin
On 2020-07-12 05:59, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this error > > lib/decompress_bunzip2.c:671:13: warning: Result of 'malloc' is converted > to a pointer of type 'unsigned int', which is incompatible with sizeof > operand type 'int'

[PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

2020-07-12 Thread trix
From: Tom Rix clang static analysis flags this error lib/decompress_bunzip2.c:671:13: warning: Result of 'malloc' is converted to a pointer of type 'unsigned int', which is incompatible with sizeof operand type 'int' [unix.MallocSizeof] bd->dbuf = large_malloc(bd->dbufSize *