Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2016-01-06 Thread Vinod Koul
On Tue, Dec 22, 2015 at 10:24:49PM +0530, Shevchenko, Andriy wrote: > On Mon, 2015-12-21 at 21:34 +0200, Andy Shevchenko wrote: > > On Mon, 2015-12-21 at 19:10 +, Mans Rullgard wrote: > > > The datasheet requires that the LLP_[SD]_EN bits be cleared > > > whenever > > > LLP.LOC is zero, i.e.

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2016-01-06 Thread Vinod Koul
On Tue, Dec 22, 2015 at 10:24:49PM +0530, Shevchenko, Andriy wrote: > On Mon, 2015-12-21 at 21:34 +0200, Andy Shevchenko wrote: > > On Mon, 2015-12-21 at 19:10 +, Mans Rullgard wrote: > > > The datasheet requires that the LLP_[SD]_EN bits be cleared > > > whenever > > > LLP.LOC is zero, i.e.

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-22 Thread Shevchenko, Andriy
On Mon, 2015-12-21 at 21:34 +0200, Andy Shevchenko wrote: > On Mon, 2015-12-21 at 19:10 +, Mans Rullgard wrote: > > The datasheet requires that the LLP_[SD]_EN bits be cleared > > whenever > > LLP.LOC is zero, i.e. in the last descriptor of a multi-block > > chain. > > Make the driver do this.

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-22 Thread Shevchenko, Andriy
On Mon, 2015-12-21 at 21:34 +0200, Andy Shevchenko wrote: > On Mon, 2015-12-21 at 19:10 +, Mans Rullgard wrote: > > The datasheet requires that the LLP_[SD]_EN bits be cleared > > whenever > > LLP.LOC is zero, i.e. in the last descriptor of a multi-block > > chain. > > Make the driver do this.

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Viresh Kumar
On 21-12-15, 19:10, Mans Rullgard wrote: > The datasheet requires that the LLP_[SD]_EN bits be cleared whenever > LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. > Make the driver do this. > > Signed-off-by: Mans Rullgard > --- > drivers/dma/dw/core.c | 2 ++ > 1 file

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Andy Shevchenko
On Mon, 2015-12-21 at 19:10 +, Mans Rullgard wrote: > The datasheet requires that the LLP_[SD]_EN bits be cleared whenever > LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. > Make the driver do this. Acked-by: Andy Shevchenko > > Signed-off-by: Mans Rullgard > --- >  

[PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Mans Rullgard
The datasheet requires that the LLP_[SD]_EN bits be cleared whenever LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. Make the driver do this. Signed-off-by: Mans Rullgard --- drivers/dma/dw/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/dw/core.c

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Andy Shevchenko
On Mon, 2015-12-21 at 19:10 +, Mans Rullgard wrote: > The datasheet requires that the LLP_[SD]_EN bits be cleared whenever > LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. > Make the driver do this. Acked-by: Andy Shevchenko > >

[PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Mans Rullgard
The datasheet requires that the LLP_[SD]_EN bits be cleared whenever LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. Make the driver do this. Signed-off-by: Mans Rullgard --- drivers/dma/dw/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Viresh Kumar
On 21-12-15, 19:10, Mans Rullgard wrote: > The datasheet requires that the LLP_[SD]_EN bits be cleared whenever > LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. > Make the driver do this. > > Signed-off-by: Mans Rullgard > --- > drivers/dma/dw/core.c | 2 ++