Hi Jeffrey,
On Tue, May 24, 2016 at 05:31:41PM +0800, jeffrey.lin wrote:
> Hi Dmitry:
> >
> > BUILD_BUG_ON((RM_FW_PAGE_SIZE % RM_BL_WRT_PKG_SIZE) != 0);
> >
> > for (i = 0; i < RM_FW_PAGE_SIZE / RM_BL_WRT_PKG_SIZE; i++) {
> > buf[BL_HEADER] = RM_CMD_BOOT_PAGE_WRT;
> >
Hi Dmitry:
>
> BUILD_BUG_ON((RM_FW_PAGE_SIZE % RM_BL_WRT_PKG_SIZE) != 0);
>
> for (i = 0; i < RM_FW_PAGE_SIZE / RM_BL_WRT_PKG_SIZE; i++) {
> buf[BL_HEADER] = RM_CMD_BOOT_PAGE_WRT;
> buf[BL_PAGE_STR] = i ? 0xff : 0;
Change to buf[BL_PAGE_STR] = page_idx ? 0xff
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile |1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 1208
3 files changed, 1221 insertions(+)
create mode 1006
Hi Jeffrey,
On Mon, May 23, 2016 at 10:43:53PM +0800, jeffrey.lin wrote:
> Hi Dmitry:
>
> >static int raydium_i2c_read_message(struct i2c_client *client,
> > u32 addr, void *data, size_t len)
> >{
> > __le32 le_addr;
> > size_t xfer_len;
> > u32 shift_a
Hi Dmitry:
>static int raydium_i2c_read_message(struct i2c_client *client,
> u32 addr, void *data, size_t len)
>{
> __le32 le_addr;
> size_t xfer_len;
> u32 shift_addr;
> int error;
>
> while (len) {
> xfer_len = min_t(s
On May 22, 2016 2:32:59 AM PDT, "jeffrey.lin" wrote:
>Hi Dmitry:
>
>+static int raydium_i2c_read_message(struct i2c_client *client,
>+ u32 addr, void *data, size_t len)
>+{
>+ __be32 be_addr;
>+ size_t xfer_len;
>+ int error;
>+
>+ while (len) {
Hi Dmitry:
>> if (len < RM_BL_WRT_PKG_SIZE) {
>> buf[BL_PKG_IDX] = 4;
>Why 4???
4 is trigger index for write flash. Our page write size is 128 bytes,
but in order to meet maximum I2C bus read/write byte limite and need
fill full all pages of 128 bytes. So that
Hi Dmitry:
+static int raydium_i2c_read_message(struct i2c_client *client,
+ u32 addr, void *data, size_t len)
+{
+ __be32 be_addr;
+ size_t xfer_len;
+ int error;
+
+ while (len) {
+ xfer_len = min_t(size_t, len, RM_MAX_READ_
On Wed, May 18, 2016 at 12:07:02AM +0800, jeffrey.lin wrote:
> Hi Dmitry:
> > >static int raydium_i2c_read_message(struct i2c_client *client,
> > > u32 addr, void *data, size_t len)
> > >{
> > > __be32 be_addr;
> > > size_t xfer_len;
> > > int error;
> > > whil
Hi Dmitry:
> >static int raydium_i2c_read_message(struct i2c_client *client,
> > u32 addr, void *data, size_t len)
> >{
> > __be32 be_addr;
> > size_t xfer_len;
> > int error;
> > while (len) {
> > xfer_len = min_t(size_t, len, RM_MAX_READ
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile |1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 1208
3 files changed, 1221 insertions(+)
create mode 1006
On Mon, May 16, 2016 at 09:41:45AM -0700, Dmitry Torokhov wrote:
> On Mon, May 16, 2016 at 11:46:51PM +0800, jeffrey.lin wrote:
> > Hi Dmitry:
> > I've finished issues under the format you suggested as below.
> >
> > >#define RM_RESET_MSG_ADDR 0x4004
> > >#define RM_FASTBOOT_MSG_ADDR 0x
On Mon, May 16, 2016 at 11:46:51PM +0800, jeffrey.lin wrote:
> Hi Dmitry:
> I've finished issues under the format you suggested as below.
>
> >#define RM_RESET_MSG_ADDR0x4004
> >#define RM_FASTBOOT_MSG_ADDR 0x5620
>
> >#define RM_MAX_READ_SIZE 63
> change maximum read size to 56 b
>static int raydium_i2c_do_update_firmware(struct raydium_data *ts,
>const struct firmware *fw)
>{
> struct i2c_client *client = ts->client;
> const void *data;
> size_t data_len;
> size_t len;
> int page_nr;
> int i;
>
Hi Dmitry:
I've finished issues under the format you suggested as below.
>#define RM_RESET_MSG_ADDR 0x4004
>#define RM_FASTBOOT_MSG_ADDR 0x5620
>#define RM_MAX_READ_SIZE 63
change maximum read size to 56 bytes
#define RM_MAX_READ_SIZE56
>#define RM_CONTACT_X_POS
Hi Dmitry:
This patch you submitted had some problems. I still debug in progress. Should I
comment the issues in this patch or create a new patch if I finish the issues?
>static int raydium_i2c_fastboot(struct i2c_client *client)
> {
>- static const u8 boot_cmd[] = { 0x50, 0x00, 0x06, 0x20
Hi Jeffrey,
On Fri, Apr 29, 2016 at 05:45:13PM +0800, jeffrey.lin wrote:
> Raydium I2C touch driver.
>
> Signed-off-by: jeffrey.lin
I was looking at the driver and there were a few issues (buffer
overflows, forgetting releasing firmware, general flow, etc), that I
tried correcting in the attache
Hi Dmitry:
I've made a mistake as touch points data over "MAX_PKG_SIZE".This mistake will
result in memory overwrite, so that I update a new patch to upstream.
New patch I assign a new definition "MAX_RD_PKG_LEN" for maxinum I2C read
command to prevent touch points data package over I2C bus buf
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile |1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 1208
3 files changed, 1221 insertions(+)
create mode 1006
Hi Dmitry:
About question "In my previous e-mail I requested you to enumerate changes that
are made to the driver, compared to the previous version(s). There were also a
few questions that I did not get answer for."
In order to improve flash read/write security of boot loader. We increase
hand
Hi Jeffrey,
On Fri, Apr 29, 2016 at 05:45:13PM +0800, jeffrey.lin wrote:
> Raydium I2C touch driver.
>
In my previous e-mail I requested you to enumerate changes that are made
to the driver, compared to the previous version(s). There were also a
few questions that I did not get answer for.
Also
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile |1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 1207
3 files changed, 1220 insertions(+)
create mode 1006
Hi Dan,
On Fri, Apr 22, 2016 at 06:01:08PM +0800, dan.huang wrote:
> From: "jeffrey.lin"
>
> Raydium I2C touch driver.
>
> Signed-off-by: jeffrey.lin
When you are sending a patch over you need to add your sign-off to it.
Also I am still getting compile errors/warnings:
CC [M] drivers/inp
From: "jeffrey.lin"
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile |1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 1172
3 files changed, 1185 insertion
emc.com.tw; Roger Yang (楊鎮瑋);
KP Li (李昆倍); Albert Shieh (謝欣瑋); linux-kernel@vger.kernel.org;
linux-in...@vger.kernel.org; devicet...@vger.kernel.org
Subject: RE: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Hi Dmitry:
Thank you for your response.
Actually, we didn'
g;
devicet...@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Hi Jeffrey,
On Fri, Mar 25, 2016 at 01:21:09PM +0800, jeffrey.lin wrote:
> +#define MAX_PACKET_SIZE 60
...
> +#define RAYDIUM_FW_PAGESIZE 128
...
> +
> +sta
Hi Jeffrey,
On Fri, Mar 25, 2016 at 01:21:09PM +0800, jeffrey.lin wrote:
> +#define MAX_PACKET_SIZE 60
...
> +#define RAYDIUM_FW_PAGESIZE 128
...
> +
> +static int raydium_i2c_send(struct i2c_client *client,
> + u8 addr, u8 *data, size_t len)
> +{
> + u8 buf[MAX_PACKET_SIZE +
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 932 +
3 files changed, 945 insertions(+)
create mode 100644
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 13 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 932 +
3 files changed, 946 insertions(+)
create mode 100644
On Tue, Mar 15, 2016 at 04:44:17PM +0800, jeffrey.lin wrote:
> Raydium I2C touch driver.
>
> Signed-off-by: jeffrey.lin
> ---
> .../devicetree/bindings/input/raydium_i2c_ts.txt | 23 +
> .../devicetree/bindings/vendor-prefixes.txt| 1 +
It is generally preferred to split bindings fr
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
.../devicetree/bindings/input/raydium_i2c_ts.txt | 23 +
.../devicetree/bindings/vendor-prefixes.txt| 1 +
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
Shieh (謝欣瑋);
linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org;
devicet...@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
Hi Jeffrey,
On Thu, Mar 03, 2016 at 02:42:11PM +0800, jeffrey.lin wrote:
> Raydium I2C touch driver.
>
>
Hi Jeffrey,
On Thu, Mar 03, 2016 at 02:42:11PM +0800, jeffrey.lin wrote:
> Raydium I2C touch driver.
>
> Signed-off-by: jeffrey.lin
> ---
> drivers/input/touchscreen/Kconfig | 13 +
> drivers/input/touchscreen/Makefile | 1 +
> drivers/input/touchscreen/raydium_i2c_ts.c | 95
Raydium I2C touch driver.
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 13 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/raydium_i2c_ts.c | 953 +
3 files changed, 967 insertions(+)
create mode 100644
On Thu, 2016-03-03 at 03:14 +, Jeffrey Lin (林義章) wrote:
> Hi Joe:
> Thank you for your response. I'll follow your comments in next version.
OK, btw: the below looks very odd
> > +static int raydium_i2c_send_message(struct i2c_client *client,
> > + size_t len, void *data)
> > +{
> > + int
i (李昆倍); Albert Shieh (謝欣瑋);
linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org;
devicet...@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
On Thu, 2016-03-03 at 10:29 +0800, jeffrey.lin wrote:
> This patch is porting Raydium I2C touc
On Thu, 2016-03-03 at 10:29 +0800, jeffrey.lin wrote:
> This patch is porting Raydium I2C touch driver. Developer can enable raydium
> touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS".
trivial comments:
> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c
> b/drivers/input/touch
This patch is porting Raydium I2C touch driver. Developer can enable raydium
touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscr
(楊鎮瑋);
KP Li (李昆倍); linux-kernel@vger.kernel.org; linux-in...@vger.kernel.org;
devicet...@vger.kernel.org
Subject: Re: [PATCH] driver: input :touchscreen : add Raydium I2C touch driver
file
Please adjust the indentation.
julia
On Fri, 26 Feb 2016, kbuild test robot wrote:
> Hi jeffrey.lin,
&
Please adjust the indentation.
julia
On Fri, 26 Feb 2016, kbuild test robot wrote:
> Hi jeffrey.lin,
>
> [auto build test WARNING on input/next]
> [also build test WARNING on v4.5-rc5 next-20160226]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the
This patch is porting Raydium I2C touch driver. Developer can enable raydium
touch driver by modifying define
"CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchsc
This patch is porting Raydium I2C touch driver. Developer can enable raydium
touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscr
Hi Jeffrey,
On Thu, Jan 21, 2016 at 12:02:58PM +0800, Jeffrey Lin wrote:
> This patch is porting Raydium I2C touch driver. Developer can enable raydium
> touch driver by modifying define
> "CONFIG_TOUCHSCREEN_RM_TS".
Thank you for making changes, please see my comments below.
>
> Signed-off-by
This patch is porting Raydium I2C touch driver. Developer can enable raydium
touch driver by modifying define
"CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey.lin
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/rm31
On Tue, Jan 06, 2015 at 11:43:54AM -0800, Jeremiah Mahler wrote:
> On Tue, Jan 06, 2015 at 05:25:50PM +0800, jeffrey.lin wrote:
> > From: "jeffrey.lin"
> >
> > This patch is porting Raydium I2C touch driver. Developer can enable
> > raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM
On Tue, Jan 06, 2015 at 05:25:50PM +0800, jeffrey.lin wrote:
> From: "jeffrey.lin"
>
> This patch is porting Raydium I2C touch driver. Developer can enable
> raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS".
>
> Signed-off-by: jeffrey@rad-ic.com
You need your full legal
From: "jeffrey.lin"
This patch is porting Raydium I2C touch driver. Developer can enable
raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey@rad-ic.com
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
From: "jeffrey.lin"
This patch is porting Raydium I2C touch driver. Developer can enable
raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey@rad-ic.com
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
Hi Jeffrey,
On December 5, 2014 12:15:01 AM PST, "jeffrey.lin" wrote:
>From: "jeffrey.lin"
>
>This patch is porting Raydium I2C touch driver. Developer can enable
>raydium touch driver by modifying define
>"CONFIG_TOUCHSCREEN_RM_TS".
>
>Signed-off-by: jeffrey@rad-ic.com
>---
> drivers/input/
From: "jeffrey.lin"
This patch is porting Raydium I2C touch driver. Developer can enable raydium
touch driver by modifying define
"CONFIG_TOUCHSCREEN_RM_TS".
Signed-off-by: jeffrey@rad-ic.com
---
drivers/input/touchscreen/Kconfig | 12
drivers/input/touchscreen/Makefile | 1
Hi Jeffrey,
On Fri, Nov 14, 2014 at 03:19:22PM +0800, jeffrey.lin wrote:
> From: "jeffrey.lin"
>
> this patch is porting Raydium I2C touch driver.
Thank you for your submission.
> Developer can enable
> Raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM31100"
> in config/base.c
Hi Jeffrey,
On Thu, Nov 13, 2014 at 11:19 PM, jeffrey.lin wrote:
> this patch is porting Raydium I2C touch driver. Developer can enable
> Raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM31100"
> in config/base.config
>
> Change-Id: Idae54cc4bca17f321a1d0895a8b59680bf9af859
This
From: "jeffrey.lin"
this patch is porting Raydium I2C touch driver. Developer can enable
Raydium touch driver by modifying define "CONFIG_TOUCHSCREEN_RM31100"
in config/base.config
Change-Id: Idae54cc4bca17f321a1d0895a8b59680bf9af859
Signed-off-by: jeffrey@rad-ic.com
chromeos: config: ad
53 matches
Mail list logo
