Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Rafael J. Wysocki
On Tue, Jul 10, 2018 at 8:19 AM, Kishon Vijay Abraham I wrote: > +Mark, Liam > > Hi, > > On Tuesday 10 July 2018 03:36 AM, Bjorn Helgaas wrote: >> [+cc Kishon] >> >> On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: >>> >>> On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: On Fri,

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Rafael J. Wysocki
On Tue, Jul 10, 2018 at 8:19 AM, Kishon Vijay Abraham I wrote: > +Mark, Liam > > Hi, > > On Tuesday 10 July 2018 03:36 AM, Bjorn Helgaas wrote: >> [+cc Kishon] >> >> On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: >>> >>> On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: On Fri,

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Rafael J. Wysocki
On Tue, Jul 10, 2018 at 12:06 AM, Bjorn Helgaas wrote: > [+cc Kishon] > > On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: >> >> On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: >> > On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki >> > wrote: >> >> >> >> From: Rafael J. Wysocki

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Rafael J. Wysocki
On Tue, Jul 10, 2018 at 12:06 AM, Bjorn Helgaas wrote: > [+cc Kishon] > > On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: >> >> On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: >> > On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki >> > wrote: >> >> >> >> From: Rafael J. Wysocki

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Pingfan Liu
On Fri, Jul 6, 2018 at 6:01 PM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > The devices_kset_move_last() call in really_probe() is a mistake > as it may cause parents to follow children in the devices_kset list > which then causes system shutdown to fail. Namely, if a device has >

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Pingfan Liu
On Fri, Jul 6, 2018 at 6:01 PM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > The devices_kset_move_last() call in really_probe() is a mistake > as it may cause parents to follow children in the devices_kset list > which then causes system shutdown to fail. Namely, if a device has >

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Kishon Vijay Abraham I
+Mark, Liam Hi, On Tuesday 10 July 2018 03:36 AM, Bjorn Helgaas wrote: > [+cc Kishon] > > On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: >> >> On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: >>> On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: From: Rafael J.

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-10 Thread Kishon Vijay Abraham I
+Mark, Liam Hi, On Tuesday 10 July 2018 03:36 AM, Bjorn Helgaas wrote: > [+cc Kishon] > > On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: >> >> On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: >>> On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: From: Rafael J.

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-09 Thread Bjorn Helgaas
[+cc Kishon] On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: > > On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: > > On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: > >> > >> From: Rafael J. Wysocki > >> > >> The devices_kset_move_last() call in really_probe() is a

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-09 Thread Bjorn Helgaas
[+cc Kishon] On Mon, Jul 9, 2018 at 4:35 PM Rafael J. Wysocki wrote: > > On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: > > On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: > >> > >> From: Rafael J. Wysocki > >> > >> The devices_kset_move_last() call in really_probe() is a

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: > On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: >> >> From: Rafael J. Wysocki >> >> The devices_kset_move_last() call in really_probe() is a mistake >> as it may cause parents to follow children in the devices_kset list >> which

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 3:57 PM, Bjorn Helgaas wrote: > On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: >> >> From: Rafael J. Wysocki >> >> The devices_kset_move_last() call in really_probe() is a mistake >> as it may cause parents to follow children in the devices_kset list >> which

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-09 Thread Bjorn Helgaas
On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > The devices_kset_move_last() call in really_probe() is a mistake > as it may cause parents to follow children in the devices_kset list > which then causes system shutdown to fail. Namely, if a device has >

Re: [PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-09 Thread Bjorn Helgaas
On Fri, Jul 6, 2018 at 5:01 AM Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > The devices_kset_move_last() call in really_probe() is a mistake > as it may cause parents to follow children in the devices_kset list > which then causes system shutdown to fail. Namely, if a device has >

[PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The devices_kset_move_last() call in really_probe() is a mistake as it may cause parents to follow children in the devices_kset list which then causes system shutdown to fail. Namely, if a device has children before really_probe() is called for it (which is not

[PATCH] driver core: Drop devices_kset_move_last() call from really_probe()

2018-07-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The devices_kset_move_last() call in really_probe() is a mistake as it may cause parents to follow children in the devices_kset list which then causes system shutdown to fail. Namely, if a device has children before really_probe() is called for it (which is not