Re: [PATCH] driver core: remove define_genpd_open_function() and define_genpd_debugfs_fops()
On Mon, Dec 3, 2018 at 5:12 PM Rafael J. Wysocki wrote: > > On Sat, Dec 1, 2018 at 2:51 AM Yangtao Li wrote: > > > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such > > a macro,so remove define_genpd_open_function and define_genpd_debugfs_fops. > > Also use DEFINE_SHOW_ATTRIBUTE to simplify somecode. > > > > Signed-off-by: Yangtao Li > > It would be good at least to split the genpd changes off into a separate > patch. > > The regmap and comonent changes appear to be independent of each other > too, so I would put them into separate patches either for easier > handling. OK. MBR, Yangtao
Re: [PATCH] driver core: remove define_genpd_open_function() and define_genpd_debugfs_fops()
On Fri 2018-11-30 20:51:54, Yangtao Li wrote: > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such > a macro,so remove define_genpd_open_function and define_genpd_debugfs_fops. > Also use DEFINE_SHOW_ATTRIBUTE to simplify somecode. "and there", ", so". > Signed-off-by: Yangtao Li Otherwise looks good. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: [PATCH] driver core: remove define_genpd_open_function() and define_genpd_debugfs_fops()
On Sat, Dec 1, 2018 at 2:51 AM Yangtao Li wrote:
>
> We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such
> a macro,so remove define_genpd_open_function and define_genpd_debugfs_fops.
> Also use DEFINE_SHOW_ATTRIBUTE to simplify somecode.
>
> Signed-off-by: Yangtao Li
It would be good at least to split the genpd changes off into a separate patch.
The regmap and comonent changes appear to be independent of each other
too, so I would put them into separate patches either for easier
handling.
> ---
> drivers/base/component.c | 12 +
> drivers/base/power/domain.c | 71 +--
> drivers/base/regmap/regcache-rbtree.c | 12 +
> drivers/base/regmap/regmap-debugfs.c | 12 +
> 4 files changed, 27 insertions(+), 80 deletions(-)
>
> diff --git a/drivers/base/component.c b/drivers/base/component.c
> index e8d676fad0c9..ddcea8739c12 100644
> --- a/drivers/base/component.c
> +++ b/drivers/base/component.c
> @@ -85,17 +85,7 @@ static int component_devices_show(struct seq_file *s, void
> *data)
> return 0;
> }
>
> -static int component_devices_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, component_devices_show, inode->i_private);
> -}
> -
> -static const struct file_operations component_devices_fops = {
> - .open = component_devices_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(component_devices);
>
> static int __init component_debug_init(void)
> {
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 7f38a92b444a..10a61d6147d0 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2671,7 +2671,7 @@ static int genpd_summary_one(struct seq_file *s,
> return 0;
> }
>
> -static int genpd_summary_show(struct seq_file *s, void *data)
> +static int summary_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd;
> int ret = 0;
> @@ -2694,7 +2694,7 @@ static int genpd_summary_show(struct seq_file *s, void
> *data)
> return ret;
> }
>
> -static int genpd_status_show(struct seq_file *s, void *data)
> +static int status_show(struct seq_file *s, void *data)
> {
> static const char * const status_lookup[] = {
> [GPD_STATE_ACTIVE] = "on",
> @@ -2721,7 +2721,7 @@ static int genpd_status_show(struct seq_file *s, void
> *data)
> return ret;
> }
>
> -static int genpd_sub_domains_show(struct seq_file *s, void *data)
> +static int sub_domains_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd = s->private;
> struct gpd_link *link;
> @@ -2738,7 +2738,7 @@ static int genpd_sub_domains_show(struct seq_file *s,
> void *data)
> return ret;
> }
>
> -static int genpd_idle_states_show(struct seq_file *s, void *data)
> +static int idle_states_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd = s->private;
> unsigned int i;
> @@ -2767,7 +2767,7 @@ static int genpd_idle_states_show(struct seq_file *s,
> void *data)
> return ret;
> }
>
> -static int genpd_active_time_show(struct seq_file *s, void *data)
> +static int active_time_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd = s->private;
> ktime_t delta = 0;
> @@ -2787,7 +2787,7 @@ static int genpd_active_time_show(struct seq_file *s,
> void *data)
> return ret;
> }
>
> -static int genpd_total_idle_time_show(struct seq_file *s, void *data)
> +static int total_idle_time_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd = s->private;
> ktime_t delta = 0, total = 0;
> @@ -2815,7 +2815,7 @@ static int genpd_total_idle_time_show(struct seq_file
> *s, void *data)
> }
>
>
> -static int genpd_devices_show(struct seq_file *s, void *data)
> +static int devices_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd = s->private;
> struct pm_domain_data *pm_data;
> @@ -2841,7 +2841,7 @@ static int genpd_devices_show(struct seq_file *s, void
> *data)
> return ret;
> }
>
> -static int genpd_perf_state_show(struct seq_file *s, void *data)
> +static int perf_state_show(struct seq_file *s, void *data)
> {
> struct generic_pm_domain *genpd = s->private;
>
> @@ -2854,37 +2854,14 @@ static int genpd_perf_state_show(struct seq_file *s,
> void *data)
> return 0;
> }
>
> -#define define_genpd_open_function(name) \
> -static int genpd_##name##_open(struct inode *inode, struct file *file) \
> -{ \
> - return single_open(file, genpd_##name##_show, inode->i_private); \
> -}
> -
> -define_genpd_open_function(summary);
> -define_genpd_open_function(status);
> -define_genpd_open_function(sub_domains);
> -define_genpd_open_function(idle_states);
> -define_genpd_open_function(active_time);
> -de
[PATCH] driver core: remove define_genpd_open_function() and define_genpd_debugfs_fops()
We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define such
a macro,so remove define_genpd_open_function and define_genpd_debugfs_fops.
Also use DEFINE_SHOW_ATTRIBUTE to simplify somecode.
Signed-off-by: Yangtao Li
---
drivers/base/component.c | 12 +
drivers/base/power/domain.c | 71 +--
drivers/base/regmap/regcache-rbtree.c | 12 +
drivers/base/regmap/regmap-debugfs.c | 12 +
4 files changed, 27 insertions(+), 80 deletions(-)
diff --git a/drivers/base/component.c b/drivers/base/component.c
index e8d676fad0c9..ddcea8739c12 100644
--- a/drivers/base/component.c
+++ b/drivers/base/component.c
@@ -85,17 +85,7 @@ static int component_devices_show(struct seq_file *s, void
*data)
return 0;
}
-static int component_devices_open(struct inode *inode, struct file *file)
-{
- return single_open(file, component_devices_show, inode->i_private);
-}
-
-static const struct file_operations component_devices_fops = {
- .open = component_devices_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(component_devices);
static int __init component_debug_init(void)
{
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 7f38a92b444a..10a61d6147d0 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2671,7 +2671,7 @@ static int genpd_summary_one(struct seq_file *s,
return 0;
}
-static int genpd_summary_show(struct seq_file *s, void *data)
+static int summary_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd;
int ret = 0;
@@ -2694,7 +2694,7 @@ static int genpd_summary_show(struct seq_file *s, void
*data)
return ret;
}
-static int genpd_status_show(struct seq_file *s, void *data)
+static int status_show(struct seq_file *s, void *data)
{
static const char * const status_lookup[] = {
[GPD_STATE_ACTIVE] = "on",
@@ -2721,7 +2721,7 @@ static int genpd_status_show(struct seq_file *s, void
*data)
return ret;
}
-static int genpd_sub_domains_show(struct seq_file *s, void *data)
+static int sub_domains_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd = s->private;
struct gpd_link *link;
@@ -2738,7 +2738,7 @@ static int genpd_sub_domains_show(struct seq_file *s,
void *data)
return ret;
}
-static int genpd_idle_states_show(struct seq_file *s, void *data)
+static int idle_states_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd = s->private;
unsigned int i;
@@ -2767,7 +2767,7 @@ static int genpd_idle_states_show(struct seq_file *s,
void *data)
return ret;
}
-static int genpd_active_time_show(struct seq_file *s, void *data)
+static int active_time_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd = s->private;
ktime_t delta = 0;
@@ -2787,7 +2787,7 @@ static int genpd_active_time_show(struct seq_file *s,
void *data)
return ret;
}
-static int genpd_total_idle_time_show(struct seq_file *s, void *data)
+static int total_idle_time_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd = s->private;
ktime_t delta = 0, total = 0;
@@ -2815,7 +2815,7 @@ static int genpd_total_idle_time_show(struct seq_file *s,
void *data)
}
-static int genpd_devices_show(struct seq_file *s, void *data)
+static int devices_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd = s->private;
struct pm_domain_data *pm_data;
@@ -2841,7 +2841,7 @@ static int genpd_devices_show(struct seq_file *s, void
*data)
return ret;
}
-static int genpd_perf_state_show(struct seq_file *s, void *data)
+static int perf_state_show(struct seq_file *s, void *data)
{
struct generic_pm_domain *genpd = s->private;
@@ -2854,37 +2854,14 @@ static int genpd_perf_state_show(struct seq_file *s,
void *data)
return 0;
}
-#define define_genpd_open_function(name) \
-static int genpd_##name##_open(struct inode *inode, struct file *file) \
-{ \
- return single_open(file, genpd_##name##_show, inode->i_private); \
-}
-
-define_genpd_open_function(summary);
-define_genpd_open_function(status);
-define_genpd_open_function(sub_domains);
-define_genpd_open_function(idle_states);
-define_genpd_open_function(active_time);
-define_genpd_open_function(total_idle_time);
-define_genpd_open_function(devices);
-define_genpd_open_function(perf_state);
-
-#define define_genpd_debugfs_fops(name) \
-static const struct file_operations genpd_##name##_fops = { \
- .open = genpd_##name##_open, \
- .read = seq_read, \
- .llseek = seq_lseek, \
- .release = single_release, \
-}
-
-define_genpd_debugfs_fops(summary);
-define_genpd_debugfs_fops(status);
-define_genpd_debugfs_fops(sub_domains);
-define_genpd_debugfs_fops(idle_states);
