Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-08-01 Thread Michael Ellerman
On Tue, 2019-07-30 at 04:37:04 UTC, Stephen Rothwell wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-31 Thread Michael Ellerman
Kees Cook writes: > On Wed, Jul 31, 2019 at 12:28:55AM +1000, Michael Ellerman wrote: >> Stephen Rothwell writes: >> > Mark switch cases where we are expecting to fall through. >> > >> > This patch fixes the following warning (Building: powerpc): >> > >> > drivers/macintosh/smu.c: In function

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-30 Thread Benjamin Herrenschmidt
On Tue, 2019-07-30 at 10:07 -0700, Kees Cook wrote: > > > Why do we think it's an expected fall through? I can't really > > convince > > myself from the surrounding code that it's definitely intentional. > > Yeah, good question. Just now when I went looking for who > used

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-30 Thread Kees Cook
On Wed, Jul 31, 2019 at 12:28:55AM +1000, Michael Ellerman wrote: > Stephen Rothwell writes: > > Mark switch cases where we are expecting to fall through. > > > > This patch fixes the following warning (Building: powerpc): > > > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > >

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-30 Thread Stephen Rothwell
Hi Michael, On Wed, 31 Jul 2019 00:28:55 +1000 Michael Ellerman wrote: > > Why do we think it's an expected fall through? I can't really convince > myself from the surrounding code that it's definitely intentional. Its been that way since this code was introduced by commit 0365ba7fb1fa

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-30 Thread Michael Ellerman
Stephen Rothwell writes: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this statement may fall through >

Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-29 Thread Stephen Rothwell
Hi all, On Tue, 30 Jul 2019 14:37:04 +1000 Stephen Rothwell wrote: > > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning:

[PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

2019-07-29 Thread Stephen Rothwell
Mark switch cases where we are expecting to fall through. This patch fixes the following warning (Building: powerpc): drivers/macintosh/smu.c: In function 'smu_queue_i2c': drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-Wimplicit-fallthrough=] cmd->info.devaddr &=