Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-08-17 Thread Artem Bityutskiy
On Wed, 2012-07-11 at 10:58 +0200, Julia Lawall wrote: > From: Julia Lawall > > dev_get_platdata returns a pointer, so the failure value would be NULL > rather than a negative integer. > > The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) Pushed to l2-mtd.git, thanks!

Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-08-17 Thread Artem Bityutskiy
On Wed, 2012-07-11 at 10:58 +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr dev_get_platdata returns a pointer, so the failure value would be NULL rather than a negative integer. The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) Pushed to

Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-16 Thread Stefan Roese
On Wednesday 11 July 2012 10:58:38 Julia Lawall wrote: > From: Julia Lawall > > dev_get_platdata returns a pointer, so the failure value would be NULL > rather than a negative integer. > > The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) > > // > @@ > expression

Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-16 Thread Stefan Roese
On Wednesday 11 July 2012 10:58:38 Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr dev_get_platdata returns a pointer, so the failure value would be NULL rather than a negative integer. The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // smpl @@

Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-11 Thread viresh kumar
Adding spear-devel mailing list in cc. @Shiraz: Can you update ST's mailing list address in entire MAINTAINERS file, so that people can include ST's list easily? On 11/07/12 09:58, Julia Lawall wrote: > From: Julia Lawall > > dev_get_platdata returns a pointer, so the failure value would be

[PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-11 Thread Julia Lawall
From: Julia Lawall dev_get_platdata returns a pointer, so the failure value would be NULL rather than a negative integer. The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @@ expression x,e; statement S1,S2; @@ *x = dev_get_platdata(...) ... when != x = e *if (x

[PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-11 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr dev_get_platdata returns a pointer, so the failure value would be NULL rather than a negative integer. The semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // smpl @@ expression x,e; statement S1,S2; @@ *x = dev_get_platdata(...)

Re: [PATCH] drivers/mtd/devices/spear_smi.c: failure test for null rather than negative integer

2012-07-11 Thread viresh kumar
Adding spear-devel mailing list in cc. @Shiraz: Can you update ST's mailing list address in entire MAINTAINERS file, so that people can include ST's list easily? On 11/07/12 09:58, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr dev_get_platdata returns a pointer, so the failure