Re: [PATCH] drivers: net: xgene: Remove unnecessary forward declarations

[David Miller]

From: Nathan Chancellor 
Date: Mon, 10 Dec 2018 21:20:30 -0700

> Clang warns:
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c:33:36: warning:
> tentative array definition assumed to have one element
> static const struct acpi_device_id xgene_enet_acpi_match[];
>^
> 1 warning generated.
> 
> Both xgene_enet_acpi_match and xgene_enet_of_match are defined before
> their uses at the bottom of the file so this is unnecessary. When
> CONFIG_ACPI is disabled, ACPI_PTR becomes NULL so xgene_enet_acpi_match
> doesn't need to be defined.
> 
> Signed-off-by: Nathan Chancellor 

Applied.

[PATCH] drivers: net: xgene: Remove unnecessary forward declarations

[Nathan Chancellor]

Clang warns:

drivers/net/ethernet/apm/xgene/xgene_enet_main.c:33:36: warning:
tentative array definition assumed to have one element
static const struct acpi_device_id xgene_enet_acpi_match[];
   ^
1 warning generated.

Both xgene_enet_acpi_match and xgene_enet_of_match are defined before
their uses at the bottom of the file so this is unnecessary. When
CONFIG_ACPI is disabled, ACPI_PTR becomes NULL so xgene_enet_acpi_match
doesn't need to be defined.

Signed-off-by: Nathan Chancellor 
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c 
b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 3b889efddf78..50dd6bf176d0 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -29,9 +29,6 @@
 #define RES_RING_CSR   1
 #define RES_RING_CMD   2
 
-static const struct of_device_id xgene_enet_of_match[];
-static const struct acpi_device_id xgene_enet_acpi_match[];
-
 static void xgene_enet_init_bufpool(struct xgene_enet_desc_ring *buf_pool)
 {
struct xgene_enet_raw_desc16 *raw_desc;
-- 
2.20.0